vrr/unsloth
2
0
Fork 0
mirror of https://github.com/unslothai/unsloth.git synced 2026-10-22 06:20:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 44

Studio: raise the startup bundle budget for #14247 (#14258)

Browse source 
## Summary

Main is over the startup bundle budget again, so `Frontend build +
bundle sanity` fails on every PR based on it:

```
over the startup budget: transfer 2012.0 KB > 2011.9 KB, raw 6681.8 KB > 6680.6 KB      (main at 26e246d407)
```

#14247 (Developer mode opt-in for experimental CPU video generation)
added 1,777 B raw / 654 B transfer to the startup chunks. It merged
without raising the limits.

## Cause

`#14247` touches eager startup code. Its new strings land in
`i18n/locales/en.ts` (the English catalog ships in the startup chunks),
and the developer-mode flag is read from `__root.tsx`,
`app-sidebar.tsx`, `config/env.ts` and `config/hardware-verdict.ts`. The
settings section itself is lazy. This is small real growth with no lazy
home. The other commits since the last measurement (#14204, #14239,
#14249) change no frontend code.

## Change

- **`check-bundle-budget.ts`:** a BUDGET comment entry for #14247, and
both limits moved to the measured build plus a 160 B raw / 189 B
transfer margin:
  - `rawBytes`: 6,840,888 -> 6,842,343.
  - `transferBytes`: 2,060,219 -> 2,060,510.

## Testing

One machine and build, Node 24, exact byte totals from the budget
script. CI has matched this machine to the byte on earlier budget
changes.

| tree | raw B | transfer B |
|---|---|---|
| `88afa84b87` (before #14247) | 6,840,406 | 2,059,667 |
| main `26e246d407` | 6,842,183 | 2,060,321 |

- **Main against the old limits:** `over the startup budget: transfer
2012.0 KB > 2011.9 KB, raw 6681.8 KB > 6680.6 KB`.
- **With this change:** `within budget (0.2 KB transfer, 0.2 KB raw to
spare)`, 96 chunks.
This commit is contained in:
Daniel Han 2026-10-19 06:30:09 -07:00 • committed by GitHub
parent 26e246d407
commit 46e4f50bea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
studio/frontend/scripts/check-bundle-budget.ts
View file

@ -266,8 +266,13 @@ export const BUDGET = {
// (6,826,504 -> 6,827,946 B raw, 2,054,599 -> 2,055,322 B transfer against 9faa995217, one machine and build,
// Node 24, chunk count unchanged at 96): the speech slot routing, evicted-model reports and Voice tab rows sit in
// the audio hook, chat adapter and settings chunks the startup set already loads. Raised by that growth.
transferBytes: 2_060_219,
rawBytes: 6_840_888,
// Developer mode opt-in for experimental CPU video generation (#14247) adds 1,777 B raw / 654 B transfer
// (6,840,406 -> 6,842,183 B raw, 2,059,667 -> 2,060,321 B transfer against 88afa84b87 and 26e246d407, one machine
// and build, Node 24, 96 chunks): its strings join the eager English catalog and the developer-mode
// flag is read by the eager shell (__root.tsx, app-sidebar.tsx, env.ts, hardware-verdict.ts). Raised by that
// growth, to the measured build plus a 160 B raw / 189 B transfer margin.
transferBytes: 2_060_510,
rawBytes: 6_842_343,
};
// The chunk count is reported but not budgeted. Splitting a page out of the entry raises it while lowering the