Pulse/scripts/test-vm-disk.sh
pulse-triage[bot] 41bc99d68f Bound the complete passive VM preflight read
Apply the existing ten-second deadline to both qm and its response reader. Stop only the local collection group even when a producer exits with an inherited pipe or a reader ignores TERM. Preserve byte limits, independent failures, private output and the refusal to probe or change a guest; test actual owned-reader termination and the mirrored help.

Contract-Neutral: Passive operator diagnostics and existing help only; Proxmox polling, guest-agent admission, APIs, storage, permissions and service behaviour are unchanged.
Change-source: pulse-maintainer
2026-10-12 00:10:22 +01:00

191 lines
6.9 KiB
Bash
Executable file

#!/usr/bin/env bash
# Passive Proxmox preflight only. A lock read is not a synchronisation gate:
# a backup can start immediately afterwards. Never send guest-agent commands.
set -euo pipefail
usage() {
printf '%s\n' 'Usage: test-vm-disk.sh VMID' \
'Read local VM status and current configuration on its Proxmox host.' \
'No guest-agent, guest filesystem, ACL or service changes are made.'
}
if [[ $# -eq 1 && $1 == --help ]]; then
usage
exit 0
fi
if [[ $# -ne 1 || ! $1 =~ ^[1-9][0-9]{0,8}$ ]]; then
usage >&2
exit 2
fi
vmid=$1
for command in qm timeout python3 bash; do
if ! command -v "$command" >/dev/null 2>&1; then
printf 'Required command unavailable: %s. Run on the owning Proxmox host.\n' "$command" >&2
exit 1
fi
done
read_failure() {
local operation=$1 code=$2
if [[ $code -eq 124 || $code -eq 137 ]]; then
printf 'VM %s read timed out; no guest-agent commands were sent.\n' "$operation" >&2
else
printf 'VM %s read failed (exit %s); no guest-agent commands were sent.\n' "$operation" "$code" >&2
fi
printf '%s\n' 'Check the VM ID, owning host and local read permissions. Inspect any error privately.' >&2
exit 1
}
read_bounded() {
local operation=$1 destination=$2 limit=$3 response reader_code producer_code code
shift 3
# Validate bytes before Bash command substitution can discard NULs or
# trailing newlines. Close oversized replies after limit + 1 bytes; never
# parse a prefix as a complete configuration or retain raw config on disk.
# The final private status suffix preserves producer and reader failures
# independently, even when they happen to use the same exit code.
response=$(
set +e
# The deadline belongs to the complete pipeline. A producer can exit
# while a descendant retains stdout, or the response reader can stall.
# KILL ends only this local read group, including TERM-resistant readers;
# a grace period can lose them when their collection shell exits first.
timeout --signal=KILL 10s bash -s -- "$limit" "$@" 2>/dev/null <<'PULSE_VM_READ'
limit=$1
shift
set +e
"$@" </dev/null 2>/dev/null |
python3 -I -c '
import sys
limit = int(sys.argv[1])
data = sys.stdin.buffer.read(limit + 1)
if len(data) > limit:
sys.exit(80)
try:
data.decode("utf-8", errors="strict")
except UnicodeDecodeError:
sys.exit(81)
if b"\0" in data:
sys.exit(81)
sys.stdout.buffer.write(data)
' "$limit" 2>/dev/null
codes=("${PIPESTATUS[@]}")
printf '\nVM_READ_STATUS %s %s' "${codes[0]}" "${codes[1]}"
PULSE_VM_READ
code=$?
if [[ $code -ne 0 ]]; then
# A deadline or failed collection shell has no complete response.
# Keep that exit separate from any bytes buffered before it failed.
printf '\nVM_READ_STATUS %s 0' "$code"
fi
)
read -r producer_code reader_code <<< "${response##*$'\nVM_READ_STATUS '}"
case "$reader_code" in
80)
printf 'VM %s response exceeded the %s-byte limit; preflight incomplete.\n' "$operation" "$limit" >&2
exit 1
;;
81)
printf 'VM %s read contained non-text bytes; preflight incomplete.\n' "$operation" >&2
exit 1
;;
0) ;;
*) read_failure "$operation" "$reader_code" ;;
esac
if [[ $producer_code -ne 0 ]]; then
read_failure "$operation" "$producer_code"
fi
printf -v "$destination" '%s' "${response%$'\nVM_READ_STATUS '*}"
}
printf '%s\n' 'Passive VM preflight: no guest-agent commands will be sent.'
# Bound even host-local reads. Do not print raw config or command errors:
# those can contain private guest names, paths and other infrastructure data.
read_bounded status status_output 256 qm status "$vmid"
# qm emits a newline-terminated status. Preserve the existing acceptance of
# trailing newlines, but only after the complete bounded byte read succeeds.
while [[ $status_output == *$'\n' ]]; do status_output=${status_output%$'\n'}; done
case "$status_output" in
'status: running') status=running ;;
'status: stopped') status=stopped ;;
*) printf '%s\n' 'VM status response was not understood; preflight incomplete.' >&2; exit 1 ;;
esac
printf 'VM status: %s\n' "$status"
read_bounded configuration config 65536 qm config "$vmid" --current
if [[ -z $config ]]; then
printf '%s\n' 'VM current configuration was empty; preflight incomplete.' >&2
exit 1
fi
agent_seen=false
lock_seen=false
field_seen=false
agent_value=''
lock_value=''
while IFS= read -r line; do
if [[ $line =~ ^[[:space:]]*$ || $line =~ ^[[:space:]]*# ]]; then
continue
fi
# qm's fields are unindented lowercase keys. Do not let one valid field
# turn malformed/truncated lock or agent lines into an absent setting.
# Unknown well-formed fields remain valid; never echo an unparsed line.
if [[ ! $line =~ ^[a-z][a-z0-9_-]*: ]]; then
printf '%s\n' 'VM current configuration contains an unrecognised line; preflight incomplete.' >&2
exit 1
fi
field_seen=true
case "$line" in
agent:*)
if [[ $agent_seen == true ]]; then
printf '%s\n' 'Repeated agent configuration; preflight incomplete.' >&2
exit 1
fi
agent_seen=true
agent_value=${line#agent:}
agent_value=${agent_value//[[:space:]]/}
;;
lock:*)
if [[ $lock_seen == true ]]; then
printf '%s\n' 'Repeated VM lock configuration; preflight incomplete.' >&2
exit 1
fi
lock_seen=true
lock_value=${line#lock:}
lock_value=${lock_value//[[:space:]]/}
;;
esac
done <<< "$config"
if [[ $field_seen != true ]]; then
printf '%s\n' 'VM current configuration was not understood; preflight incomplete.' >&2
exit 1
fi
agent=disabled
if [[ $agent_seen == true ]]; then
agent=unknown
enabled_options=0
IFS=, read -r -a options <<< "$agent_value"
for option in "${options[@]}"; do
case "$option" in
1|enabled=1) agent=enabled; enabled_options=$((enabled_options + 1)) ;;
0|enabled=0) agent=disabled; enabled_options=$((enabled_options + 1)) ;;
esac
done
if [[ $enabled_options -ne 1 ]]; then
agent=unknown
fi
fi
printf 'Guest agent configured: %s (not a responsiveness test).\n' "$agent"
if [[ $lock_seen == true ]]; then
if [[ $lock_value == backup ]]; then
printf '%s\n' 'VM lock: backup. Defer guest-agent diagnostics and configuration changes.'
else
printf '%s\n' 'VM lock: present or unknown. Check the existing Proxmox task before making changes.'
fi
else
printf '%s\n' 'VM lock: not reported. This does not establish that a backup is idle or the guest is thawed.'
fi
printf '%s\n' 'Read-only preflight completed. Disk freshness, guest-agent responsiveness and guest thaw were not tested.'