vrr/CodeNomad
2
0
Fork 0
mirror of https://github.com/NeuralNomadsAI/CodeNomad.git synced 2026-10-21 05:06:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3
CodeNomad/dev-docs/SESSION_ENVIRONMENT.md
Pascal André bdac05bb25
fix(environment): refresh profile variables before each prompt (#714) 
## Summary

Apply the existing CodeNomad profile environment **before every prompt,
custom command and session-shell send**, then forward the request only
after OpenCode acknowledges it. This makes profile changes available to
local commands even when the shared daemon is already running.

No per-conversation settings UI, polling, session-opening writes or
daemon restart. The implementation lives in the shared server for
Electron/Tauri/web parity.

close #711; awaiting reporter validation rather than automatically
closing the issue.

## Implementation

- Build a complete execution-host snapshot; preserve PATH and other
inherited values, normalize Windows key collisions, and exclude internal
authentication/storage variables. WSL reads its selected distro's
environment instead of sending Windows PATH/HOME.
- Apply after ownership checks and worktree mutation admission, using
the pinned native connection. Fail the send on environment errors, stale
connection or disconnect; never log the native environment request body.
- Update help and failure messages in every locale. Changes and removals
take effect on each conversation's next send.

## Validation

- Server suite: **586 passed, 2 platform skips**.
- Focused UI send/SDK/authority tests: **112 passed**.
- Server, UI and Electron typechecks; production UI build passed.
- **OpenCode 2.0.9 / Windows native fixture:** real WorkspaceManager +
guarded proxy + native shells, two conversations, changes/removal, no
mutation on read, Git Bash, unchanged daemon PID. Independent
configuration/database/port; only the fixture service was stopped.
- Reproduction: `node scripts/test-session-environment-native.mjs
<absolute-opencode-executable>`.

## Scope

This changes local session command environments, not provider/MCP/LSP
configuration or daemon-internal temporary files. The native environment
belongs to a session: another client or a new send during existing work
can replace it. Queued prompts do not get individual snapshots, and
native-created subagents are not automatically intercepted. Details:
`dev-docs/SESSION_ENVIRONMENT.md`.

Existing oversized files touched narrowly:
`packages/server/src/server/http-server.ts` (~2,300 lines),
`packages/server/src/workspaces/manager.ts` (~1,200 lines), and
`packages/ui/src/lib/i18n/messages/*/settings.ts` (~600 lines each).
2026-09-19 18:18:56 +02:00

4.1 KiB
Raw Permalink Blame History

Profile environment at send time

The profile's existing server.environmentVariables setting is applied before every native session.prompt, session.command, and session.shell request sent through CodeNomad. The server awaits session.environment({ sessionID, variables }) before forwarding the original request. Electron, Tauri and web clients use the same server path.

Opening, reading or creating a conversation does not set its environment. Saving settings does not walk existing sessions. Every conversation receives the current profile settings on its next send, including resumed conversations and forks that the user subsequently prompts. There is no polling, per-session settings store, applied-version cache, plugin or daemon restart.

Implementation

  • The guarded instance proxy applies the environment only after ownership checks and acquisition of the worktree mutation fence. Both writes use the acquired connection; a stale connection or disconnected request prevents forwarding.
  • WorkspaceManager.getSessionEnvironment reads current settings for each send.
  • workspaces/session-environment.ts builds the complete snapshot required by the native replacement API. On the host this is the backend process environment plus profile overrides, merging keys case-insensitively on Windows.
  • With WSL, an asynchronous, bounded wsl.exe --distribution <distro> --exec env -0 reads the execution environment for each send. Windows PATH/HOME are not copied into Linux. Configured paths must be meaningful inside the selected distro.
  • Clearing an override restores the execution host's inherited value (or removes the key when absent there), rather than retaining the previous session value.
  • Internal server authentication variables and OpenCode storage ownership variables are omitted. Full snapshots never pass through the browser. Native request errors are not logged or reflected, since they can include these values.
  • A failed or unsupported environment call fails the send with a localized error; it does not silently send using stale values or retry the mutation. Existing UI send failure/draft handling remains responsible for restoring the user's input.

For host execution the additional work is an in-memory merge and one local API request per send. WSL additionally launches the environment reader. No performance claim is made without measurement.

Scope

This controls the targeted conversation's local shell commands. It does not reconfigure providers, MCP/LSP servers, independent PTYs, location-only shells, or the daemon's own temporary files. Existing startup-variable behavior remains: allowed variables are also passed when CodeNomad starts a stopped service.

The environment belongs to the native session, not the client or the individual prompt. Other clients can replace it. A send while a session is already working can affect its subsequent command launches; running processes keep their existing environment. Queued prompts do not capture separate environment snapshots.

OpenCode-created child sessions that execute without a CodeNomad send are outside this interception point. Do not claim automatic subagent inheritance. The native API is not an atomic environment-plus-prompt transaction; no global cross-client isolation is added by this change.

Validation

Unit/HTTP integration tests cover full snapshots, Windows key casing, WSL host selection, credential exclusion, per-send updates/removal, prompt/command/shell ordering, read-only behavior, denied sessions, failure redaction, stale connection fencing, worktree deletion and disconnect cancellation.

Run the real native regression against an explicitly selected CLI:

node scripts/test-session-environment-native.mjs <absolute-opencode-executable>

It creates isolated service configuration, state and database with its own port; uses the real WorkspaceManager, proxy and native shells; checks two conversations, settings changes/removal, read-only behavior and an unchanged daemon PID; and stops only that isolated service. Windows also exercises Git Bash at its standard installation path. No provider call or existing conversation is used.