mirror of
https://github.com/unslothai/unsloth.git
synced 2026-10-21 05:11:50 +00:00
* Trim comments in studio/backend routes, utils and the installers
Comment-only pass over 109 files under studio/backend/routes,
studio/backend/utils and the studio installers.
13,591 -> 8,613 comment lines (-36.6%)
954,968 -> 615,254 comment characters (-35.6%)
No comment line exceeds 120 columns.
Nothing outside comments changes: no code, docstrings, string literals,
licence headers or pragmas. FastAPI route handler docstrings are visible
in the OpenAPI schema, so they are byte-identical to the base commit;
this was checked with the AST gate running strict, treating docstrings
as code.
Kept throughout: the invariants the code cannot state. Two examples of
the class, both of which now sit on one line rather than a paragraph:
CUDA_DEVICE_ORDER is pinned to PCI_BUS_ID so torch, nvidia-smi and
CUDA_VISIBLE_DEVICES share one index space, and process_lifetime records
no pid below a floor because killpg(1, sig) is kill(-1, sig).
* Use plain dashes instead of em dashes in comments
Comment tokens only. Em dashes inside string literals are code and are left
untouched, so the diff stays comment-only and the code-identity gate holds.
* Put the section banners back
The trim removed the rule-line comments that index these files. They are not
decoration: tests locate a region by finding its banner and end it on the next
one, so worker.py losing its whole numbered index broke
test_rocm_support.py, test_grouped_mm_rdna4_fallback.py and
test_audio_decode_load_order.py while the code-identity gate stayed green.
Each banner is restored above the code line it preceded at 1d2679f. Where that
anchor is not unique in the current file the banner is left out rather than
guessed at, so this under-restores by design.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Repair the banner restore: drop duplicate headings, keep the blank line
The scripted restore re-added each section banner without removing the
de-bannered plain heading the trim had left behind, so a heading appeared
twice, once ruled and once bare. It also inserted the banner flush against the
next line of code where the base had a blank line after it, which turns a
section separator into a doc comment for whichever def follows.
Both are the same fault the trim itself was being screened for, introduced by
the remediation rather than by the trim.
* Correct five comments that no longer describe their code
Each of these lost the clause that made it true, so the surviving sentence
states something the code does not do:
- settings.py keep_empty asserted an explicit clear always keeps a row; the
code gates on _fallback_supplies_extra_args.
- vram_budget_settings.py read as an argument against the two-sided check
rather than for it; the conclusion and the do-not-refactor note were gone.
- install_node_prebuilt.py claimed an unconditional keep-existing; the lines
below compute pin_mismatch and refuse a digest that is not the pin.
- mcp_servers.py inverted the subject: the FAILURE belongs to the old config,
not the row.
- llama_cpp_freshness.py implied it always offers; the return refuses a bare
base over a mix install at the same base.
Also drops a stranded fragment in unsloth_freeze_report.py that described
nothing after its block was removed.
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
219 lines
7.7 KiB
Python
219 lines
7.7 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
|
|
|
|
"""Bounded reads of a log file for the Settings > Logs viewer.
|
|
|
|
The active session log is never rotated and only pruned at startup (run.py
|
|
retains the newest 20 files), so it can be many GB by the time someone opens
|
|
this. Everything here seeks from the end and reads a bounded window, so cost
|
|
does not scale with file size.
|
|
|
|
read_tail and read_since return REDACTED lines. The raw reader is private so a
|
|
later caller cannot forget.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import base64
|
|
import json
|
|
import os
|
|
from dataclasses import dataclass, field
|
|
from pathlib import Path
|
|
from typing import Optional
|
|
|
|
from utils.log_redaction import redact_log_text
|
|
|
|
BLOCK_BYTES = 65_536
|
|
DEFAULT_TAIL_LINES = 1_000
|
|
MAX_TAIL_LINES = 2_000 # == MAX_LINES_PER_RESPONSE: a larger ?lines= was silently capped
|
|
# /api is not gzipped (GZipMiddleware is scoped to the assets sub-app), so this
|
|
# is what actually goes on the wire on the first paint.
|
|
MAX_TAIL_BYTES = 1_048_576
|
|
MAX_APPEND_BYTES = 524_288
|
|
MAX_LINE_BYTES = 32_768
|
|
MAX_LINES_PER_RESPONSE = 2_000
|
|
|
|
_CURSOR_PREFIX = "c1."
|
|
|
|
|
|
@dataclass
|
|
class ReadResult:
|
|
lines: list[str] = field(default_factory = list)
|
|
cursor: Optional[str] = None
|
|
reset: bool = False
|
|
reset_reason: Optional[str] = None
|
|
dropped_bytes: int = 0
|
|
truncated_head: bool = False
|
|
more_pending: bool = False
|
|
size_bytes: int = 0
|
|
|
|
|
|
def _file_key(stat: os.stat_result, name: str) -> str:
|
|
# Identity only: st_ctime_ns changes on append on Linux, which made every poll look like a rotation and resend the
|
|
# whole tail; st_ino can be 0 on Windows, so name and device carry it there.
|
|
return f"{name}|{stat.st_dev}|{stat.st_ino}"
|
|
|
|
|
|
def encode_cursor(key: str, offset: int) -> str:
|
|
raw = json.dumps({"k": key, "o": int(offset)}, separators = (",", ":")).encode("utf-8")
|
|
return _CURSOR_PREFIX + base64.urlsafe_b64encode(raw).decode("ascii").rstrip("=")
|
|
|
|
|
|
def decode_cursor(cursor: Optional[str]) -> Optional[tuple[str, int]]:
|
|
"""None for anything unusable: a foreign cursor is answered with a fresh
|
|
tail, never an error, so a poll loop cannot flash failures."""
|
|
if not cursor or not isinstance(cursor, str) or not cursor.startswith(_CURSOR_PREFIX):
|
|
return None
|
|
body = cursor[len(_CURSOR_PREFIX) :]
|
|
try:
|
|
padded = body + "=" * (-len(body) % 4)
|
|
payload = json.loads(base64.urlsafe_b64decode(padded.encode("ascii")).decode("utf-8"))
|
|
key = payload["k"]
|
|
offset = int(payload["o"])
|
|
except Exception:
|
|
return None
|
|
if not isinstance(key, str) or offset < 0:
|
|
return None
|
|
return key, offset
|
|
|
|
|
|
def _split_lines(data: bytes, *, drop_partial_head: bool) -> tuple[list[str], bool]:
|
|
truncated_head = False
|
|
if drop_partial_head:
|
|
first = data.find(b"\n")
|
|
remainder = b"" if first == -1 else data[first + 1 :]
|
|
if not remainder:
|
|
# The whole window sits inside ONE record (no line break, or only the terminator at the end), so dropping
|
|
# the partial head left nothing: a record bigger than the window (native dump, \r-only progress run, giant
|
|
# JSON line) rendered an EMPTY pane on a megabyte log while the cursor still advanced past it. Keep the
|
|
# record's tail.
|
|
body = data if first == -1 else data[:first]
|
|
remainder = body[-MAX_LINE_BYTES:]
|
|
data = remainder
|
|
truncated_head = True
|
|
text = data.decode("utf-8", errors = "replace")
|
|
raw = text.split("\n")
|
|
if raw and raw[-1] == "":
|
|
raw.pop()
|
|
lines: list[str] = []
|
|
for line in raw:
|
|
line = line.rstrip("\r")
|
|
# An enormous line is split rather than dropped, so nothing is lost.
|
|
while len(line) > MAX_LINE_BYTES:
|
|
lines.append(line[:MAX_LINE_BYTES])
|
|
line = line[MAX_LINE_BYTES:]
|
|
lines.append(line)
|
|
return lines, truncated_head
|
|
|
|
|
|
def _redact(lines: list[str]) -> list[str]:
|
|
return [redact_log_text(line) for line in lines]
|
|
|
|
|
|
def read_tail(path: Path, max_lines: int = DEFAULT_TAIL_LINES) -> ReadResult:
|
|
max_lines = max(1, min(int(max_lines), MAX_TAIL_LINES))
|
|
stat = path.stat()
|
|
size = stat.st_size
|
|
result = ReadResult(size_bytes = size)
|
|
result.cursor = encode_cursor(_file_key(stat, path.name), size)
|
|
result.reset = True
|
|
if size == 0:
|
|
return result
|
|
|
|
chunks: list[bytes] = []
|
|
pos = size
|
|
newlines = 0
|
|
scanned = 0
|
|
with open(path, "rb") as handle:
|
|
while pos > 0 and newlines <= max_lines and scanned < MAX_TAIL_BYTES:
|
|
step = min(BLOCK_BYTES, pos, MAX_TAIL_BYTES - scanned)
|
|
pos -= step
|
|
handle.seek(pos)
|
|
block = handle.read(step)
|
|
if not block:
|
|
break
|
|
chunks.insert(0, block)
|
|
newlines += block.count(b"\n")
|
|
scanned += len(block)
|
|
|
|
data = b"".join(chunks)
|
|
lines, truncated = _split_lines(data, drop_partial_head = pos > 0)
|
|
result.truncated_head = truncated
|
|
if len(lines) > max_lines:
|
|
lines = lines[-max_lines:]
|
|
result.truncated_head = True
|
|
result.lines = _redact(lines[-MAX_LINES_PER_RESPONSE:])
|
|
return result
|
|
|
|
|
|
def read_since(
|
|
path: Path,
|
|
cursor: Optional[str],
|
|
max_lines: int = DEFAULT_TAIL_LINES,
|
|
) -> ReadResult:
|
|
"""Appended lines only, or a fresh tail when the cursor cannot apply."""
|
|
decoded = decode_cursor(cursor)
|
|
if decoded is None:
|
|
result = read_tail(path, max_lines)
|
|
result.reset_reason = "initial" if not cursor else "cursor_stale"
|
|
return result
|
|
|
|
key, offset = decoded
|
|
stat = path.stat()
|
|
current_key = _file_key(stat, path.name)
|
|
size = stat.st_size
|
|
|
|
if current_key != key:
|
|
result = read_tail(path, max_lines)
|
|
result.reset_reason = "rotated"
|
|
return result
|
|
if offset > size:
|
|
# Reopened in "w" mode, or truncated underneath us.
|
|
result = read_tail(path, max_lines)
|
|
result.reset_reason = "truncated"
|
|
return result
|
|
|
|
result = ReadResult(size_bytes = size)
|
|
if offset == size:
|
|
result.cursor = encode_cursor(current_key, offset)
|
|
return result
|
|
|
|
start = offset
|
|
pending = size - offset
|
|
if pending > MAX_APPEND_BYTES:
|
|
start = size - MAX_APPEND_BYTES
|
|
result.dropped_bytes = start - offset
|
|
with open(path, "rb") as handle:
|
|
handle.seek(start)
|
|
data = handle.read(size - start)
|
|
|
|
# Stop at the last newline and leave the cursor before the partial line
|
|
last_newline = data.rfind(b"\n")
|
|
if last_newline == -1:
|
|
if len(data) < MAX_LINE_BYTES:
|
|
result.cursor = encode_cursor(current_key, start)
|
|
return result
|
|
consumed = len(data)
|
|
body = data
|
|
else:
|
|
consumed = last_newline + 1
|
|
body = data[:consumed]
|
|
|
|
# Cap by BYTES before decoding so the cursor stops where the response stops: slicing decoded lines threw away the
|
|
# oldest of a burst while advancing past them, reporting dropped_bytes = 0.
|
|
# A model load logging more than MAX_LINES_PER_RESPONSE lines between polls lost the head of its own failure; the
|
|
# remainder now arrives next poll.
|
|
newline_count = body.count(b"\n")
|
|
if newline_count > MAX_LINES_PER_RESPONSE:
|
|
cut = -1
|
|
for _ in range(MAX_LINES_PER_RESPONSE):
|
|
cut = body.find(b"\n", cut + 1)
|
|
consumed = cut + 1
|
|
body = body[:consumed]
|
|
result.more_pending = True
|
|
|
|
lines, truncated = _split_lines(body, drop_partial_head = result.dropped_bytes > 0)
|
|
result.truncated_head = truncated
|
|
result.lines = _redact(lines)
|
|
result.cursor = encode_cursor(current_key, start + consumed)
|
|
return result
|