mirror of
https://github.com/unslothai/unsloth.git
synced 2026-10-21 14:00:32 +00:00
Comment and docstring changes only, in test files, split out of #12968 so the test-only part can merge first.
145 lines
4.8 KiB
Python
145 lines
4.8 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-only
|
|
# Copyright 2026-present the Unsloth AI Inc. team. All rights reserved.
|
|
|
|
"""docker/build.sh must pass commits, not branch names, or Docker reuses a stale git-install layer."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import shutil
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[2]
|
|
BUILD_SH = REPO_ROOT / "docker" / "build.sh"
|
|
|
|
pytestmark = pytest.mark.skipif(shutil.which("bash") is None, reason = "needs bash")
|
|
|
|
UNSLOTH_SHA = "a" * 40
|
|
ZOO_SHA = "b" * 40
|
|
NB_SHA = "c" * 40
|
|
|
|
|
|
def _stub(path: Path, body: str) -> None:
|
|
path.write_text("#!/usr/bin/env bash\n" + body, encoding = "utf-8")
|
|
path.chmod(0o755)
|
|
|
|
|
|
def _run(
|
|
tmp_path: Path,
|
|
git_body: str,
|
|
env_extra: dict[str, str] | None = None,
|
|
stubs: dict[str, str] | None = None,
|
|
):
|
|
bin_dir = tmp_path / "bin"
|
|
bin_dir.mkdir()
|
|
args_file = tmp_path / "docker-args.txt"
|
|
for name, body in (stubs or {}).items():
|
|
_stub(bin_dir / name, body)
|
|
_stub(bin_dir / "git", git_body)
|
|
_stub(bin_dir / "docker", f'printf "%s\\n" "$@" > {args_file}\n')
|
|
_stub(bin_dir / "curl", "exit 1\n")
|
|
|
|
env = dict(os.environ)
|
|
env["PATH"] = f"{bin_dir}{os.pathsep}{env['PATH']}"
|
|
env.update(env_extra or {})
|
|
proc = subprocess.run(
|
|
["bash", str(BUILD_SH)],
|
|
env = env,
|
|
capture_output = True,
|
|
text = True,
|
|
cwd = str(tmp_path),
|
|
)
|
|
assert proc.returncode == 0, proc.stdout + proc.stderr
|
|
argv = args_file.read_text(encoding = "utf-8").splitlines() if args_file.exists() else []
|
|
return proc, argv
|
|
|
|
|
|
def _build_arg(argv: list[str], name: str) -> str:
|
|
for index, item in enumerate(argv):
|
|
if item == "--build-arg" and argv[index + 1].startswith(f"{name}="):
|
|
return argv[index + 1].split("=", 1)[1]
|
|
raise AssertionError(f"--build-arg {name} was never passed: {argv}")
|
|
|
|
|
|
LS_REMOTE_STUB = f"""
|
|
if [ "$1" = "ls-remote" ]; then
|
|
case "$2" in
|
|
*unsloth-zoo*) echo -e "{ZOO_SHA}\\tHEAD" ;;
|
|
*notebooks*) echo -e "{NB_SHA}\\tHEAD" ;;
|
|
*) echo -e "{UNSLOTH_SHA}\\tHEAD" ;;
|
|
esac
|
|
exit 0
|
|
fi
|
|
exit 0
|
|
"""
|
|
|
|
|
|
def test_the_default_main_refs_are_frozen_to_commits(tmp_path):
|
|
_proc, argv = _run(tmp_path, LS_REMOTE_STUB)
|
|
assert _build_arg(argv, "UNSLOTH_REF") == UNSLOTH_SHA, (
|
|
"a mutable 'main' build arg is byte-identical across rebuilds, so docker "
|
|
"reuses the cached install layer and silently ships a stale image"
|
|
)
|
|
assert _build_arg(argv, "UNSLOTH_ZOO_REF") == ZOO_SHA
|
|
assert _build_arg(argv, "UNSLOTH_NOTEBOOKS_REF") == NB_SHA
|
|
|
|
|
|
def test_the_smoke_test_message_names_the_build_hosts_own_gpu(tmp_path):
|
|
"""It named a B200 on every host, including the ones that have no NVIDIA GPU."""
|
|
proc, _argv = _run(
|
|
tmp_path, LS_REMOTE_STUB, stubs = {"nvidia-smi": 'echo "NVIDIA GeForce RTX 3090"\n'}
|
|
)
|
|
assert "RTX 3090" in proc.stdout, proc.stdout
|
|
assert "B200" not in proc.stdout and "sm_100" not in proc.stdout
|
|
|
|
|
|
def test_the_smoke_test_message_claims_no_gpu_when_there_is_none(tmp_path):
|
|
proc, _argv = _run(tmp_path, LS_REMOTE_STUB, stubs = {"nvidia-smi": "exit 9\n"})
|
|
assert "Smoke test on this host:" in proc.stdout, proc.stdout
|
|
|
|
|
|
def test_a_failing_gpu_query_is_not_shown_as_a_gpu_name(tmp_path):
|
|
"""nvidia-smi prints its failure text on stdout; only a successful query names a GPU."""
|
|
proc, _argv = _run(
|
|
tmp_path,
|
|
LS_REMOTE_STUB,
|
|
stubs = {
|
|
"nvidia-smi": 'echo "NVIDIA-SMI has failed because it could not communicate"; exit 9\n'
|
|
},
|
|
)
|
|
assert "Smoke test on this host:" in proc.stdout, proc.stdout
|
|
assert "has failed" not in proc.stdout
|
|
|
|
|
|
def test_an_explicit_tag_is_frozen_too(tmp_path):
|
|
_proc, argv = _run(
|
|
tmp_path, LS_REMOTE_STUB, {"UNSLOTH_REF": "v2026.5.6", "UNSLOTH_ZOO_REF": "v2026.5.4"}
|
|
)
|
|
assert _build_arg(argv, "UNSLOTH_REF") == UNSLOTH_SHA
|
|
assert _build_arg(argv, "UNSLOTH_ZOO_REF") == ZOO_SHA
|
|
|
|
|
|
def test_a_sha_is_passed_through_without_a_lookup(tmp_path):
|
|
sha = "c" * 40
|
|
_proc, argv = _run(
|
|
tmp_path,
|
|
'if [ "$1" = "ls-remote" ]; then echo "ls-remote should not run" >&2; exit 3; fi\nexit 0\n',
|
|
{"UNSLOTH_REF": sha, "UNSLOTH_ZOO_REF": sha},
|
|
)
|
|
assert _build_arg(argv, "UNSLOTH_REF") == sha
|
|
assert _build_arg(argv, "UNSLOTH_ZOO_REF") == sha
|
|
|
|
|
|
def test_an_unreachable_remote_warns_and_still_builds(tmp_path):
|
|
proc, argv = _run(tmp_path, 'if [ "$1" = "ls-remote" ]; then exit 128; fi\nexit 0\n')
|
|
assert _build_arg(argv, "UNSLOTH_REF") == "main", "offline: the name is passed through"
|
|
assert _build_arg(argv, "UNSLOTH_NOTEBOOKS_REF") == "main"
|
|
assert "unreachable" in proc.stdout + proc.stderr
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(pytest.main([__file__, "-v"]))
|