unsloth

vrr/unsloth

Fork 0

mirror of https://github.com/unslothai/unsloth.git synced 2026-11-01 03:30:08 +00:00

Commit graph

Author	SHA1	Message	Date
Daniel Han	50b9deacb0	Trim comments in tests (#13844 ) Comment and docstring changes only, in test files, split out of #12968 so the test-only part can merge first.	2026-10-15 05:30:27 -07:00
Nilay	3eef688ed0	Make UNSLOTH_STUDIO_KEEP_LEGACY=0 work through docker/run.sh (#13488 ) * Make UNSLOTH_STUDIO_KEEP_LEGACY=0 work through docker/run.sh * Trim comments in PR scope --------- Co-authored-by: mahiatlinux <mahiatlinux@users.noreply.github.com>	2026-10-13 15:54:44 +13:00
Nilay	38ffe9aa94	Docker: pass JUPYTER_PORT and the notebook skip options through run.sh (#11484 ) run.sh forwards host environment through an explicit allowlist, and four variables the Docker Hub pages document were never on it, so setting them through the helper the docs recommend did nothing and printed no warning. Adds JUPYTER_PORT, UNSLOTH_SKIP_NOTEBOOK_SYNC, UNSLOTH_SKIP_NOTEBOOK_REFRESH and UNSLOTH_SKIP_GPU_CHECK to the list, and a test that derives its cases from the variable tables in DOCKERHUB.md and DOCKERHUB-ROCM.md so a documented option that stops being forwarded fails the suite. Every variable in both tables now reaches the container. Same class of bug as #11109.	2026-09-22 06:02:37 -07:00

Author

SHA1

Message

Date

Daniel Han

50b9deacb0

Trim comments in tests (#13844 )

Comment and docstring changes only, in test files, split out of #12968 so the test-only part can merge first.

2026-10-15 05:30:27 -07:00

Nilay

3eef688ed0

Make UNSLOTH_STUDIO_KEEP_LEGACY=0 work through docker/run.sh (#13488 )

* Make UNSLOTH_STUDIO_KEEP_LEGACY=0 work through docker/run.sh

* Trim comments in PR scope

---------

Co-authored-by: mahiatlinux <mahiatlinux@users.noreply.github.com>

2026-10-13 15:54:44 +13:00

Nilay

38ffe9aa94

Docker: pass JUPYTER_PORT and the notebook skip options through run.sh (#11484 )

run.sh forwards host environment through an explicit allowlist, and four variables the Docker Hub pages document were never on it, so setting them through the helper the docs recommend did nothing and printed no warning.

Adds JUPYTER_PORT, UNSLOTH_SKIP_NOTEBOOK_SYNC, UNSLOTH_SKIP_NOTEBOOK_REFRESH and UNSLOTH_SKIP_GPU_CHECK to the list, and a test that derives its cases from the variable tables in DOCKERHUB.md and DOCKERHUB-ROCM.md so a documented option that stops being forwarded fails the suite.

Every variable in both tables now reaches the container. Same class of bug as #11109.

2026-09-22 06:02:37 -07:00

3 commits