Commit graph

2 commits

Author SHA1 Message Date
Dallin Romney
17a8d22268
fix(plugin-sdk): emit revision declarations with their own compiler (#181908)
* fix(plugin-sdk): render shipped surfaces with revision tooling

Co-authored-by: RomneyDa <6581799+RomneyDa@users.noreply.github.com>

* fix(plugin-sdk): drop stale renderer argument

Co-authored-by: RomneyDa <6581799+RomneyDa@users.noreply.github.com>

* fix(release): keep SDK renderer trusted

Co-authored-by: RomneyDa <6581799+RomneyDa@users.noreply.github.com>

* fix(release): render SDK revisions with Node under Bun

Co-authored-by: RomneyDa <6581799+RomneyDa@users.noreply.github.com>

* fix(plugin-sdk): emit revision declarations with their own compiler

* fix(build): declare the emitter's compiler API edge as a declaration input

---------

Co-authored-by: roboclaw-bot <309084314+roboclaw-bot@users.noreply.github.com>
Co-authored-by: RomneyDa <6581799+RomneyDa@users.noreply.github.com>
2026-10-23 23:36:11 -07:00
Peter Steinberger
7b9615fc20
fix(plugin-sdk): API diff fails under load and on macOS temporary checkouts (#164466)
* fix(scripts): join the native compiler before reporting declaration failures

The native declaration subprocess let an emission failure escape as an
uncaught top-level rejection. Node then exited immediately, while the
TypeScript native API's close() had only ended the compiler's stdin, so
tsgo was still shutting down inside the managed process group. Under load
the managed runner reported "Managed command exited while its process
group remained active" and the real failure was lost.

Report the failure through process.exitCode instead, so the event loop
drains and joins the compiler exactly as the success path already does.

* fix(plugin-sdk): render API surfaces from canonical checkout roots

Native declaration emission sets rootDir to the realpath of the checkout,
but the renderer derived its root file names from the unresolved repoRoot.
The API diff renders revisions under os.tmpdir(), which is a symlinked
alias on macOS (/var -> /private/var), so every source landed outside
rootDir and the render failed with TS6059. Canonicalize repoRoot once when
rendering starts.
2026-10-03 15:00:33 -07:00