vrr/open-code-review
2
0
Fork 0
mirror of https://github.com/alibaba/open-code-review.git synced 2026-10-20 11:45:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6
open-code-review/bin
History
Exact
超級の新人 c590b6b606
fix(launcher): forward SIGINT/SIGTERM signals to child process (#1145) 
The Node.js launcher wrapper (bin/ocr.js) was not forwarding signals
to the Go binary child process, causing orphaned processes when the
parent received SIGINT or SIGTERM.

Changes:
- Replace spawnSync with spawn for asynchronous child process handling
- Add signal handlers for SIGINT and SIGTERM that forward signals to child
- Add error event handler for spawn failures (ENOENT, EACCES)
- Properly propagate child exit status including signal-based termination
- Add integration tests to verify signal forwarding behavior

Fixes issue where Ctrl+C or kill commands left the Go process running
after the Node.js wrapper exited.

Resolves: #1142
2026-09-07 14:19:25 +08:00
..
ocr.js fix(launcher): forward SIGINT/SIGTERM signals to child process (#1145) 2026-09-07 14:19:25 +08:00
ocr.test.js fix(launcher): forward SIGINT/SIGTERM signals to child process (#1145) 2026-09-07 14:19:25 +08:00