open-code-review/cmd/opencodereview
Jason Cat 27def8684b
Some checks are pending
CI / test (push) Waiting to run
CI / windows (push) Waiting to run
CI / cross-compile (amd64, darwin) (push) Waiting to run
CI / cross-compile (amd64, windows) (push) Waiting to run
CI / cross-compile (arm64, darwin) (push) Waiting to run
CI / cross-compile (arm64, linux) (push) Waiting to run
CI / cross-compile (arm64, windows) (push) Waiting to run
CodeQL Advanced / Analyze (go) (push) Waiting to run
CodeQL Advanced / Analyze (actions) (push) Waiting to run
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Deploy Pages / build (push) Waiting to run
Deploy Pages / deploy (push) Blocked by required conditions
plugin-contract / plugin-contract (push) Waiting to run
fix(scan): resolve --path like the filesystem and reject nonexistent paths (#1709)
* fix(scan): match --path selectors case-insensitively

On Windows and macOS a --path selector such as SRC names an existing directory (the filesystem resolves it), but filterByPaths compared selectors to git ls-files output byte-for-byte, so the scan silently selected no files and exited 0. Fold case like the other user-facing path filters (--include/--exclude, secret paths, the extension allowlist).

Refs #1708

* fix(scan): prefer the exact --path spelling before folding case

A selector now matches its own spelling first, so on a case-sensitive
filesystem --path src cannot widen to a sibling SRC/; case-insensitive
matching stays as a per-selector fallback, the repair for --path SRC on
Windows and macOS. Documented on the ocr scan page in all locales.

* fix(scan): resolve --path against the filesystem before folding case

A selector's own spelling is tried first; a spelling that names nothing
must resolve in the working tree before case folding applies, so on a
case-sensitive filesystem a wrongly-cased --path is an error instead of
a folded match or a silent empty scan. Docs updated in all locales.

* fix(scan): resolve --path selectors to their on-disk path

A selector that names nothing in its own spelling is resolved against
the working tree -- symlinks followed, on-disk case taken where the
filesystem folds it -- and only the resolved path is matched, replacing
the case-fold fallback. An empty src/docs/ therefore selects nothing on
a case-sensitive filesystem even while src/DOCS/ holds tracked files.

---------

Co-authored-by: Kite <254839944+lizhengfeng101@users.noreply.github.com>
2026-10-19 17:13:29 +08:00
..
apply_provider_field_test.go feat(providers): add AWS Bedrock as a built-in provider with native SigV4 auth (#705) 2026-08-20 10:22:45 +08:00
arg_errors.go feat(viewer): export a session to a self-contained HTML file (#1167) (#1174) 2026-09-19 11:19:10 +08:00
arg_errors_test.go feat(viewer): export a session to a self-contained HTML file (#1167) (#1174) 2026-09-19 11:19:10 +08:00
auth_cmd.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
auth_cmd_test.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
background_file.go refactor(background): treat --background and --background-file as mutually exclusive with file precedence (#1016) 2026-08-20 18:03:28 +08:00
background_file_test.go refactor(background): treat --background and --background-file as mutually exclusive with file precedence (#1016) 2026-08-20 18:03:28 +08:00
bedrock_config_test.go fix: follow up ChatGPT auth recovery and provider credentials (#1622) (#1718) 2026-10-13 12:47:24 +08:00
budget_output_test.go feat(tool): include arguments in failure details (#1152) 2026-09-03 11:56:18 +08:00
chatgpt_auth.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
chatgpt_auth_lifecycle_test.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
chatgpt_auth_test.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
chatgpt_consent_test.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
cli_reference_compare_docs_test.go feat(session): add 'ocr session rm' to delete a saved session (#1490) 2026-09-23 20:14:06 +08:00
color.go fix(cmd): suppress ANSI color when stdout is not a TTY (#927) 2026-08-19 21:51:38 +08:00
color_test.go fix(cmd): suppress ANSI color when stdout is not a TTY (#927) 2026-08-19 21:51:38 +08:00
compat_test.go fix(resume): preserve checkpoints after Ctrl-C (#902) 2026-08-14 17:42:24 +08:00
completion.go fix(cmd): report expected arguments when positional count is wrong (#892) 2026-08-13 20:44:04 +08:00
config_cmd.go fix(config): fix bad config for providers or keys that cotains dots (self-defined) (#1661) 2026-10-16 11:17:26 +08:00
config_cmd_test.go fix(config): fix bad config for providers or keys that cotains dots (self-defined) (#1661) 2026-10-16 11:17:26 +08:00
config_dispatch_test.go chore: add SPDX license headers and automated verification (#740) 2026-08-05 21:26:27 +08:00
config_runset_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
config_unset_error_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
delegate_cmd.go fix(agent): make --preview apply the same selection the review applies (#801) 2026-09-11 12:52:12 +08:00
delegate_exec_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
delegate_helpers_test.go feat(cmd): add SARIF output format (#820) 2026-08-12 18:03:34 +08:00
emit_run_result_test.go feat(tool): include arguments in failure details (#1152) 2026-09-03 11:56:18 +08:00
flag_suggest.go chore: add SPDX license headers and automated verification (#740) 2026-08-05 21:26:27 +08:00
flag_suggest_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
flags_test.go docs: use subtask instead of file/file-group in user-facing docs (#1277) 2026-09-16 03:10:35 +08:00
git.go fix(review): keep git stderr out of --commit background (#1467) 2026-09-22 12:57:38 +08:00
git_test.go fix(review): keep git stderr out of --commit background (#1467) 2026-09-22 12:57:38 +08:00
interrupt.go fix(review): exit immediately on the second signal (#1185) 2026-09-09 15:39:24 +08:00
interrupt_test.go fix(review): exit immediately on the second signal (#1185) 2026-09-09 15:39:24 +08:00
llm_cmd.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
llm_cmd_test.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
main.go fix(cli): flush telemetry before error exit (#1259) 2026-09-15 14:33:42 +08:00
main_test.go fix(config): fix bad config for providers or keys that cotains dots (self-defined) (#1661) 2026-10-16 11:17:26 +08:00
manual_e2e_retry_test.go feat(grouping): skip the grouping LLM call for small change sets (#1103) 2026-08-31 17:11:24 +08:00
misc_helpers_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
output.go fix(llmloop): count a grace-round task_done as completion (#1678) 2026-10-15 10:52:27 +08:00
output_color_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
output_file_test.go fix(output): write reports atomically (#1160) 2026-09-09 20:14:44 +08:00
output_helpers_test.go fix(llmloop): count a grace-round task_done as completion (#1678) 2026-10-15 10:52:27 +08:00
output_manifest_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
output_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
parent_cmd_test.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
procattr_unix.go chore: add SPDX license headers and automated verification (#740) 2026-08-05 21:26:27 +08:00
procattr_windows.go chore: add SPDX license headers and automated verification (#740) 2026-08-05 21:26:27 +08:00
progress_stream_e2e_test.go fix(cmd): stream review progress to stderr for json and sarif (#929) 2026-08-19 19:05:53 +08:00
provider_cmd.go fix(config): fix bad config for providers or keys that cotains dots (self-defined) (#1661) 2026-10-16 11:17:26 +08:00
provider_cmd_test.go fix(config): fix bad config for providers or keys that cotains dots (self-defined) (#1661) 2026-10-16 11:17:26 +08:00
provider_config_apply_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
provider_gateway_test.go fix: follow up ChatGPT auth recovery and provider credentials (#1622) (#1718) 2026-10-13 12:47:24 +08:00
provider_tui.go fix(config): fix bad config for providers or keys that cotains dots (self-defined) (#1661) 2026-10-16 11:17:26 +08:00
provider_tui_cpinput_test.go feat(config): resolve api_key/auth_token from a command (#236) (#605) 2026-08-17 14:40:37 +08:00
provider_tui_customform_test.go feat(providers): add AWS Bedrock as a built-in provider with native SigV4 auth (#705) 2026-08-20 10:22:45 +08:00
provider_tui_deleteconfirm_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
provider_tui_editsave_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
provider_tui_funcs_test.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
provider_tui_manualenter_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
provider_tui_modeltui_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
provider_tui_persist_test.go fix(config): fix bad config for providers or keys that cotains dots (self-defined) (#1661) 2026-10-16 11:17:26 +08:00
provider_tui_rollback_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
provider_tui_savefail_test.go feat(config): resolve api_key/auth_token from a command (#236) (#605) 2026-08-17 14:40:37 +08:00
provider_tui_test.go feat(providers): add AWS Bedrock as a built-in provider with native SigV4 auth (#705) 2026-08-20 10:22:45 +08:00
retry_fake_llm_test.go feat(grouping): skip the grouping LLM call for small change sets (#1103) 2026-08-31 17:11:24 +08:00
retry_report_e2e_test.go feat(grouping): skip the grouping LLM call for small change sets (#1103) 2026-08-31 17:11:24 +08:00
retry_report_render_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
review_cmd.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
review_cmd_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
review_helpers_test.go fix(preview): collapse provider-directory rows and keep changeset order (#1242) 2026-09-15 21:56:40 +08:00
review_mcp_more_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
review_output_order_test.go fix(output): write reports atomically (#1160) 2026-09-09 20:14:44 +08:00
review_resume_more_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
root.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
rules_check_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
rules_cmd.go feat(allowlist): add matlab support (#574) 2026-08-25 20:11:01 +08:00
rules_cmd_test.go feat(allowlist): add matlab support (#574) 2026-08-25 20:11:01 +08:00
sarif.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
sarif_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
scan_budget_json_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
scan_cmd.go feat(auth): enable ChatGPT plan reviews through public Responses (#1622) 2026-10-13 10:21:19 +08:00
scan_cmd_test.go refactor: retire per-file naming left over from grouped review (#1168) 2026-09-05 11:48:46 +08:00
scan_helpers_test.go fix(scan): align preview selection with execution (#1041) 2026-09-10 15:27:12 +08:00
scan_prompt_overflow_test.go fix(scan): record rendered prompt overflow as a failed review (#1652) 2026-10-12 19:41:07 +08:00
scan_resume_more_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
session_cmd.go feat(session): add 'ocr session rm' to delete a saved session (#1490) 2026-09-23 20:14:06 +08:00
session_cmd_test.go fix(session): preserve findings across file renames (#1529) 2026-09-22 15:56:35 +08:00
session_complete_test.go feat(cli): add --output flag to write review/scan results to a file (#852) 2026-08-24 15:37:29 +08:00
session_display_more_test.go test: raise statement coverage to 90% and enforce it in CI (#747) 2026-08-06 12:55:44 +08:00
session_rm_test.go feat(session): add 'ocr session rm' to delete a saved session (#1490) 2026-09-23 20:14:06 +08:00
shared.go fix(llm): trim environment-sourced endpoint values (#1414) 2026-09-24 17:59:47 +08:00
shared_flags.go fix(scan): resolve --path like the filesystem and reject nonexistent paths (#1709) 2026-10-19 17:13:29 +08:00
shared_llmruntime_test.go fix(llm): trim environment-sourced endpoint values (#1414) 2026-09-24 17:59:47 +08:00
shared_raw_test.go feat(raw): capture raw LLM traffic via SDK middleware (opt-in) (#1109) 2026-09-03 11:05:21 +08:00
shared_test.go fix(cmd): stream review progress to stderr for json and sarif (#929) 2026-08-19 19:05:53 +08:00
shell_unix.go chore: add SPDX license headers and automated verification (#740) 2026-08-05 21:26:27 +08:00
shell_windows.go chore: add SPDX license headers and automated verification (#740) 2026-08-05 21:26:27 +08:00
smallfiles_test.go feat(cmd, viewer): open viewer URL in default browser (#1108) 2026-09-01 20:42:40 +08:00
timeout_help_test.go fix(llm): clarify independent timeouts and deadline diagnostics (#1159) 2026-10-08 15:06:38 +08:00
version.go fix(cli): reject unexpected positional arguments (#749) 2026-08-06 21:41:07 +08:00
viewer_cmd.go feat(cmd, viewer): open viewer URL in default browser (#1108) 2026-09-01 20:42:40 +08:00
zero_args_test.go fix(cli): reject unexpected positional arguments (#749) 2026-08-06 21:41:07 +08:00