Commit graph

998 commits

Author SHA1 Message Date
Manuel Ceroni
1414f3ca44
Unify client/server terminology and fix post-NAT fields of swapped flows (#11265)
Some checks are pending
Build / build (push) Waiting to run
CIFuzz / Fuzzing (address) (push) Waiting to run
CIFuzz / Fuzzing (undefined) (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
CodeQL / Analyze-1 (push) Waiting to run
2026-11-16 12:57:15 +01:00
Ivan Nardi
2d90cbb006
Assets: the VLAN is no longer part of the key of the host assets (#11256)
* Assets journal: one entry for the assets deleted at once (#11206)

Deleting all the assets wrote one journal entry per asset, all with the
same message ("Asset deleted: all the assets of the interface have been
deleted"): useless, misleading, and pushing the other events off the
page. The same happened when deleting the assets not seen since a time.
The code is in pro.

Now every deletion of several assets at once writes a single Delete
entry, with no asset key, the number of assets and the cause:
- "Assets deleted (N): all the host assets of the interface";
- "Assets deleted (N): all the SNMP devices" (SNMP deletions were not
  journaled at all);
- "Assets deleted (N): not seen since <time>".
The deletion of a single asset keeps its own entry. The entries already
written are left as they are, so the old templates (cause_all_deleted)
are kept.

- en.lua: assets_journal.assets_deleted, cause_all_host_assets,
  cause_all_snmp_devices; assets_journal_page.host_assets and
  snmp_devices (Asset column of the entries with no key);
- rest-api-v2.json: delete/host/asset.lua and get/host/assets_journal.lua
  (empty asset key for a deletion of several assets);
- user guide (assets_journal.rst) and developer docs
  (README.assets_journal.md).

* Assets: the VLAN is no longer part of the key of the host assets (#11208)

The same IP seen on several VLANs was listed as one asset per VLAN (key
`<ifid>_<ip>@<vlan>`). The VLAN is now an attribute of the asset: the
hosts with the same IP on several VLANs update one asset, keyed
`<ifid>_<ip>@0` (the same key as before for the hosts without VLAN, so
nothing changes on installations without VLANs). The Lua side is in pro.

Schemas (SQLite, ClickHouse, ClickHouse cluster):
- new column `vlans` (ClickHouse `Array(UInt16) DEFAULT []`, SQLite TEXT
  `",15,188,"`), added with ALTER TABLE ... ADD to the existing tables;
  `vlan` is kept, as the VLAN seen last.

Host configuration (get/set host/config.lua):
- the user tags set on a host are set on the hosts of every VLAN of its
  asset (live hosts and persistent keys), with one journal entry; the
  tags are read and written for `ip@vlan` (they used to go to VLAN 0, so
  a host on another VLAN never got them);
- the optional `ifid` of the request is selected (INVALID_INTERFACE when
  it cannot be), and a host that is not active on the interface answers
  NOT_FOUND instead of failing with a Lua error.

Existing data: at startup the assets recorded per VLAN by an older
version are converted into one asset per IP address, with their journal
entries (see pro).

Assets page: a VLANs column (tables_config/assets.json), shown when the
assets of the interface have VLANs.

Docs: user guide, `README.assets_journal.md` and the new design
document `doc/developers/README.assets_vlan.md`
2026-11-16 11:01:21 +01:00
Alfredo Cardigliano
ee6e784936 Add 'Add to the expected servers' when resolving an issue 2026-11-13 15:22:05 +01:00
GabrieleDeri
9fb6e93ed5
Added traffic modle clients and servers (#11255)
* Added traffic modle clients and servers

* Update dist
2026-11-13 12:36:02 +01:00
Matteo Biscosi
1a4f483aab Removed no more used alert, changed some alert labels 2026-11-12 18:54:57 +01:00
GabrieleDeri
9436dcbbab
Added clients traffic model (#11250)
* Added clients traffic model

* Update dist
2026-11-12 18:48:37 +01:00
Alfredo Cardigliano
c5933d6143 Add tags configuration in Checks. Propagate tags to generated alerts and issues.
Some checks are pending
Build / build (push) Waiting to run
CIFuzz / Fuzzing (address) (push) Waiting to run
CIFuzz / Fuzzing (undefined) (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
CodeQL / Analyze-1 (push) Waiting to run
2026-11-12 17:58:35 +01:00
Ivan Nardi
9a401735a2
Kerberos: client principal of the flows, usernames of the hosts (#11106) (#11249)
- Live flows (packet interfaces): when the dissection ends ntopng keeps,
  from the nDPI Kerberos metadata, only the client principal
  ("user@realm", "host$@realm" for a machine), which of its names nDPI
  truncated, delegation (S4U) yes/no and the reply (OK, error code, or
  none). Flow info: the client principal, plus the error of a KRB-ERROR
  reply. Exported in Lua (protos.kerberos.*) and in the flow JSON
  ("kerberos" block), shown by the live and historical flow details.
- Hosts: the Kerberos client of a flow (the host that is not the KDC, port
  88 or 464), from reliable data only (OK reply, no delegation, no
  truncated names), gets:
  - the machine account: names.kerberos, also the name of the host with
    the lowest priority;
  - the users, as usernames of the host: a generic list of up to
    MAX_USERNAMES_PER_HOST (3) usernames, whatever the protocol, each with
    its protocol and first/last seen; when full the oldest last_seen is
    replaced.
  In memory only, local hosts only.
- Assets: kerberos_name and usernames ("<name> (<protocol>), ..."). Journal:
  the machine account as a field, the usernames as a list (one cause per
  username, added or replaced): AssetJournalCause.key,
  addJournalListCause()
- Host details REST: usernames; host names escaped
- Labels (en, it), user guide (assets journal, asset and host details)

TODO: ZMQ
2026-11-12 17:02:15 +01:00
Matteo Biscosi
1490e551d0 Standardized all ntopng Web GUI, removed no more used files, Fixed axe inconsistencies found 2026-11-12 11:24:06 +01:00
manuelceroni
e3a9e3a887 Fixed duplicated entries in the Flow Alerts filter 2026-11-12 11:04:25 +01:00
manuelceroni
f2e5ad2327 Fixed preferences search and allowed enabling preferences via global search 2026-11-12 10:23:43 +01:00
Matteo Biscosi
0f7fc522de Removed datatables.net table 2026-11-11 11:06:06 +01:00
Matteo Biscosi
272cb68b9d Removed alerts from interface details page
Some checks are pending
Build / build (push) Waiting to run
CIFuzz / Fuzzing (address) (push) Waiting to run
CIFuzz / Fuzzing (undefined) (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
CodeQL / Analyze-1 (push) Waiting to run
2026-11-10 17:07:20 +01:00
Matteo Biscosi
e1bd57016c Updated details pages to vuejs 2026-11-10 17:00:02 +01:00
Alfredo Cardigliano
d4eefd3783 Add Issues Reopen Window preference 2026-11-09 16:20:42 +01:00
GabrieleDeri
ecd2c51dfe
Added function calling to nanalyst (#11216)
Some checks are pending
Build / build (push) Waiting to run
CIFuzz / Fuzzing (address) (push) Waiting to run
CIFuzz / Fuzzing (undefined) (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
CodeQL / Analyze-1 (push) Waiting to run
* Added function calling nanalyst

* Update dist
2026-11-08 12:15:13 +01:00
GabrieleDeri
d977a14eb8
Added mosaic api key preference (#11203)
* Added mosaic api key preference

* Update dist
2026-11-06 17:58:30 +01:00
Alfredo Cardigliano
c9454a7aeb Add pref to configure max open issues
Some checks are pending
Build / build (push) Waiting to run
CIFuzz / Fuzzing (address) (push) Waiting to run
CIFuzz / Fuzzing (undefined) (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
CodeQL / Analyze-1 (push) Waiting to run
2026-11-06 15:03:02 +01:00
Alfredo Cardigliano
97704df4c7 Add preference to set min severity for alerts to contribute to issues 2026-11-06 11:04:53 +01:00
Matteo Biscosi
7ef5b099b9 Small fixes in case of interface with no traffic 2026-11-05 17:09:09 +01:00
Matteo Biscosi
e96ba784f0 Updadted if_stats.lua page 2026-11-05 16:44:55 +01:00
Matteo Biscosi
697b67d496 Updated various pages to vuejs 2026-11-04 16:25:56 +01:00
Alfredo Cardigliano
e4d9b52e83 Initial Issues implementation 2026-11-04 12:43:21 +01:00
Matteo Biscosi
9ccf15ef89 Updated pages to vuejs
Some checks are pending
Build / build (push) Waiting to run
CIFuzz / Fuzzing (address) (push) Waiting to run
CIFuzz / Fuzzing (undefined) (push) Waiting to run
CodeQL / Analyze-1 (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
2026-11-03 16:44:04 +01:00
Manuel Ceroni
ede40c247b
Implemented the asset journals GUI (#11141)
* Implemented the asset journals GUI

* Added preference and license check for the assets journal
2026-11-03 11:59:09 +01:00
Matteo Biscosi
98574894e0 Updated system pages 2026-11-03 10:58:14 +01:00
Ivan Nardi
5789677916
Assets journal: log of the changes of the assets, with their causes (#11115)
Add a journal of the assets (Enterprise L): one entry per event (an asset
created, deleted, a field changed, a tag added or removed), with when it
happened, who caused it (ntopng or the user), the action, what it is about,
and a message with its cause. Entries are never deleted.
See `doc/developers/README.assets_journal.md` for the design.

This repo:
- Table assets_journal (ClickHouse, ClickHouse cluster, SQLite).
- Causes of the changes seen in the traffic (C++): the hosts keep, for each
  change not yet dumped with their asset, its cause (the evidence and the
  flow) and send it with the asset snapshot ("journal" key). The flow is
  passed explicitly to the setters (Flow* argument); LocalHost grows by 8
  bytes (one pointer).
- The flow that creates a host is recorded (Flow constructor, and the view
  walker for the hosts of a view).
- Flow destructor (viewed interfaces): the client address is freed after
  updateView() of both hosts, that can now print the flow.
- Asset DNS name stored lowercase, as the host name.
- Preference "Enable Assets Journal" (disabled by default).
- REST handlers: user actions with the username (tags set/unset on a host,
  tag deleted).
- User documentation (Advanced Features > Assets Journal).

The Lua module, the assets code and the tests are in the pro repo.
2026-11-02 20:13:55 +01:00
Matteo Biscosi
3b8c1d2a24 Updated ddetails pages 2026-11-02 18:09:28 +01:00
Alfredo Cardigliano
e6742ff29b Fix non-admin users can shut down a live interface via pcap upload
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-A0UO9AUL
2026-11-02 15:55:42 +00:00
GabrieleDeri
b56117e9da
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-J5YN9UU6 (#11179)
* Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-TAULY9R0.

* Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-J5YN9UU6
2026-11-02 16:33:20 +01:00
GabrieleDeri
6658278558
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-TAULY9R0. (#11178) 2026-11-02 16:24:01 +01:00
Matteo Biscosi
b319c861fa Updated network menu pages 2026-11-02 16:17:12 +01:00
Ivan Nardi
67d3bd68f9 Active Scan: accept only names of modules in active_scan/modules as scan_type
Some checks are pending
Build / build (push) Waiting to run
CIFuzz / Fuzzing (address) (push) Waiting to run
CIFuzz / Fuzzing (undefined) (push) Waiting to run
CodeQL / Analyze-1 (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
Fix Lua code injection in Active Scan via `scan_type` passed to `require()`

Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-BEOPH6NT
2026-11-02 11:47:31 +01:00
Matteo Biscosi
ca2b1a4531 Reworked notifications page 2026-11-02 10:11:57 +01:00
GabrieleDeri
2edf9216a4
Added syslog page (#11158)
* Added syslog page

* Update dist
2026-10-29 18:16:59 +01:00
Matteo Biscosi
3dd04c04b3 Moved alerts page to router SPA 2026-10-29 12:41:42 +01:00
Matteo Biscosi
05be59c409 Reworked nAnalyst pages 2026-10-28 18:34:35 +01:00
GabrieleDeri
9028b8e183
Added table page refresh keeps page (#11145)
* Added table page refresh

* Update dist
2026-10-28 15:06:58 +01:00
Matteo Biscosi
50c1173ab2 Added chip+N for flow alerts 2026-10-28 11:31:09 +01:00
Matteo Biscosi
1e254c0ab7 Reworked Live Flows page 2026-10-28 11:16:50 +01:00
Matteo Biscosi
969e154477 Optimized REST API and updated documentation 2026-10-27 12:34:49 +01:00
manuelceroni
c7a08fc972 Renamed Alert Groups to Alert Overview 2026-10-27 10:52:38 +01:00
Matteo Biscosi
88276bfd6b Ported infrastracture e active monitoring tabs.
Fixed incorrect referer when reloading some pages after logout
2026-10-26 15:39:21 +01:00
GabrieleDeri
ac18b5cc2d
Added new toast component, traffic model pages improvement (#11123)
* Added new toast component, traffic model pages improvement

* Update dist
2026-10-26 12:11:22 +01:00
Matteo Biscosi
8b918fb981 Updated settings pages and optimized modules loading and REST API permissions checks 2026-10-26 10:40:38 +01:00
Matteo Biscosi
bbd3502a8c Reworked some settings pages.
Also fixed some security bugs, linting and permissions checks
2026-10-23 21:46:18 +02:00
Alfredo Cardigliano
ba97a1e73b Add missing admin checks
Some checks are pending
Build / build (push) Waiting to run
CIFuzz / Fuzzing (address) (push) Waiting to run
CIFuzz / Fuzzing (undefined) (push) Waiting to run
CodeQL / Analyze (push) Waiting to run
CodeQL / Analyze-1 (push) Waiting to run
2026-10-23 16:46:40 +02:00
Matteo Biscosi
104b59e98f Reworked some pages and optimized modules loading 2026-10-23 15:31:09 +02:00
Matteo Biscosi
3dd8b3efff Updated license page 2026-10-22 16:52:02 +02:00
GabrieleDeri
ab445aab93
table.insert to ptr ref improvement, sites doc update (#11113)
* table.insert to ptr ref improvement

* Updated sites doc
2026-10-22 16:47:05 +02:00