mirror of
https://github.com/chmouel/liseur.git
synced 2026-10-19 09:13:36 +00:00
A second round of review found three more ways the footnote change could go wrong. A book whose own security policy turns the stylesheet down was noticed only the first time. Every pass after that went on marking notes that nothing was able to hide, and reported the page as having moved when it had not. A note the reader had asked to see was put away again whenever the chapter was rebuilt, which happens when the book is closed and reopened at that spot, or when it is reached from search or the contents. The note the reader is being taken to is now left where they can see it. Going to a note also put a book's text back on the page before turning to it, and that movement was being counted as reading: it taught the speed estimate a distance nobody read and published it as progress. |
||
|---|---|---|
| .. | ||
| grimmory | ||
| lib | ||
| e2e-delete | ||
| e2e-open-external | ||
| e2e-upload | ||
| emblem-transparent | ||
| feature-graphic | ||
| generate-release-notes | ||
| grimmory-dev | ||
| icon | ||
| install | ||
| install-release | ||
| make-notes-book | ||
| README.md | ||
| release | ||
| reset-books | ||
| screenshots | ||
| store-status | ||
| test-fdroid-tags | ||
| verify-fdroid-tags | ||
| verify-footnotes | ||
| verify-reproducible | ||
| verify-wide-content | ||
hack/
Scripts used to build, test, and release Liseur. Most have a make
target wrapping them. Run make help for the short list. See
DEVELOPER.md for the full release workflow.
screenshots: Captures the screenshots used by the README,docs/SCREENSHOTS.mdand the F-Droid listing.--setupbuilds a demo shelf first (downloads a set of Standard Ebooks EPUBs, pushes them to the device, grants the library folder, seeds a highlight/note/bookmark and writes six weeks of reading sessions for the stats screens) before capturing; without it, captures from a device already set up.--setup-onlybuilds the shelf and stops, to check it.--no-dictionaryskips the definition card, which is the one capture that needs the device to reach a site.hack/screenshots --helpfor the rest of the flags.reset-books: Wipes the app's storage and the device'sBooksfolder on a connected device/emulator, then reseeds it with the same demo book shelf asscreenshots --setup, without capturing anything. Backsmake reset. Downloaded books are cached undertmp/books, shared withscreenshots.e2e-upload/e2e-delete: End-to-end checks of the two actions that reach a liseur-sync server's disk. Both drive the app through its own screens against a real server and then read that server's folder and the app's database to see what happened, so neither can pass on a mock.e2e-delete -o DIRalso writes screenshots of the sheet and the confirmation, which is where the pictures in a pull request come from.--helpfor the flags.e2e-open-external: End-to-end check that a book handed over by another app lands on the shelf. Pushes an EPUB somewhere nothing watches, opens it through the sameVIEWintent a file manager sends, and then asserts against the app's database that the book was shelved, that the reading position hangs off that shelved row, that a second handover of the same file does not shelve it twice, and that the upload offer can reach it. It runs under the "keep them here" upload policy. The script sets it through the settings screen and puts it back afterwards. This also proves that shelving a book and sending it are separate: the book reaches the shelf while no upload is attempted. Pass-u URLto name the liseur-sync server.--helpfor the flags.lib/demo-books.sh: Library sourced byscreenshots,reset-booksand thee2e-*scripts: the demo book list, the uiautomator-driven UI helpers, and the fetch/push/grant-folder logic. Not meant to be run directly.grimmory-dev: Brings up a throwaway Grimmory server in containers, seeded and ready for Liseur to connect to, so the Grimmory client is developed against the real thing rather than a reading of its source.--upstarts and seeds it,--downdeletes it and everything it held,--resetdoes both,--inforeprints the credentials. Grimmory hides its Komga compatibility shim behind an admin setting and a separate set of credentials, an "OPDS user" rather than the browser login. The script sets up both because either missing one fails in a way that does not say so. The image tag inhack/grimmory/docker-compose.ymlis pinned deliberately: a compatibility shim is exactly the thing that moves under you. The seeded shelf is larger than one catalog page on purpose, and holds one CBZ, so paging and the EPUB-only filter both have something real to work on. Everything lives undertmp/. This is developer tooling only. Nothing in Gradle, CI or the release path may depend on it.grimmory/seed-books.py: Generates the booksgrimmory-devseeds: filler EPUBs, each with a cover, plus one CBZ. Everything is generated, so no downloads and nothing copyrighted. Not meant to be run directly.install: Builds a release-signed APK (key fetched frompass) and installs it in place over the device's existing release install, keeping its data. A debug build can't do this: Android refuses an update whose signature doesn't match.install-release: Builds the release APK, signs it with the release key frompass, and installs it on a device picked viafzf.release: Runs the release process: bumpsversionCode/versionName, checks that F-Droid will see final tags but not test tags, tags, builds, publishes the GitHub release, and submits the F-Droid update. SeeDEVELOPER.mdfor the full workflow and flags.verify-fdroid-tags: Reads the live F-Droid metadata and fails closed unless a plainvX.Y.Ztag is discoverable and the supplied non-final tags are not. The release script runs it before pushing or submitting a tag.test-fdroid-tags: Runs the deterministic fixture-based tests for the tag-policy verifier. It does not contact F-Droid and is part ofmake checkand CI.generate-release-notes: Writes the GitHub release notes for a tag by asking Gemini to turn the commits since the previous tag into prose. It also reads the pull requests associated with those commits, links each described change back to its PR, and carries over a relevant screenshot from the PR body when one is present. It falls back to the F-Droid changelog if generation fails.store-status: Answers "where is Liseur published?" for all three channels at once: the last GitHub releases, what F-Droid has published and how old its index is, what its last build run did with the app, the fdroiddata metadata, any open merge request with its pipeline state, and what sits on each Google Play track. It also says when the closed track that testers are recruited into falls behind internal, who may install from it, which countries it reaches, and whether its testers come from a Google Group or an email list the API cannot read. It also prints the opt-in link they are handed. Everything but the Play section reads public sources; Play has no public answer while the app is in testing, so that one signs a token with the service account frompassand is skipped with a line when it cannot. Backsmake store-status.verify-reproducible: Builds the release APK twice from two independent clean checkouts and diffs them byte for byte, the check F-Droid's reproducible-builds requirement demands before submission.verify-wide-content: Checks that content wider than the page is measured and constrained rather than painted over the page after it (issue #67). The fix is JavaScript that runs inside the book's own document, and none of what it has to get right is visible from the JVM. The script is lifted straight out ofWideContentFit.kt, never a copy, and run against Readium's own stylesheets in headless Chrome, in a frame the size of a phone. Needs Chrome or Chromium and a prior./gradlew assembleDebug(Readium's CSS is unpacked from the AAR by the build), so it is a check to run by hand when that script changes, not part ofmake check.PORT=picks another port.verify-footnotes: The same kind of check for the notes in issue #152: that a book's notes stay out of the page until they are asked for, and that a marker drawn as an image is the size of the words around it. The script comes out ofFootnoteLayout.kt, and the cases run against Readium's CJK stylesheets, which are what it picks for the book in the issue and which nothing else here exercises. Same requirements and same reasons for staying out ofmake check.PORT=picks another port.make-notes-book: Builds the fixture book those notes are reproduced with — deliberately badly behaved in the two ways the reporter's edition is, and well behaved everywhere else, so a fix can be seen to leave the second alone. Seeded onto the shelf byreset-booksandscreenshots, and buildable on its own for opening by hand.icon: Renders the adaptive launcher icon (two vector drawables) to a flat PNG for the F-Droid listing and the README.feature-graphic: Renders the 1024x500 store feature graphic from the app's own emblem.
See also tests/, which holds the headless, assertion-shaped end-to-end
scenarios. They measure behaviour rather than walk the screen.
The e2e-* scripts here drive the UI and need a visible device.