From e4e5b468f4e73a2d002f17b509a93002fabd00db Mon Sep 17 00:00:00 2001 From: Chmouel Boudjnah Date: Fri, 4 Sep 2026 11:45:36 +0200 Subject: [PATCH] fix: Remove device target variable from Makefile commands Removed the target device variable from Android Debug Bridge commands in the Makefile. This prevented connection errors when working with multiple connected devices, ensuring commands executed on the default or only available device instead. Signed-off-by: Chmouel Boudjnah --- Makefile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 6de96167..d6c07bf5 100644 --- a/Makefile +++ b/Makefile @@ -125,23 +125,23 @@ dev: $(GRADLE) assembleDev dev-install: dev - $(ADB) $(ADB_TARGET) install -r '$(DEV_APK)' + $(ADB) install -r '$(DEV_APK)' dev-run: dev-install - $(ADB) $(ADB_TARGET) shell am start -n '$(DEV_ACTIVITY)' + $(ADB) shell am start -n '$(DEV_ACTIVITY)' dev-uninstall: - $(ADB) $(ADB_TARGET) uninstall '$(DEV_PACKAGE)' + $(ADB) uninstall '$(DEV_PACKAGE)' # Filtered by pid rather than by tag: the app logs under a dozen of them, # and the pid is the one thing that says "this build and not the other". dev-logcat: - @pid=$$($(ADB) $(ADB_TARGET) shell pidof '$(DEV_PACKAGE)' 2>/dev/null | tr -d '\r' | awk '{print $$1}'); \ + @pid=$$($(ADB) shell pidof '$(DEV_PACKAGE)' 2>/dev/null | tr -d '\r' | awk '{print $$1}'); \ if [ -z "$$pid" ]; then \ printf 'error: %s is not running; start it with make dev-run\n' '$(DEV_PACKAGE)' >&2; \ exit 1; \ fi; \ - $(ADB) $(ADB_TARGET) logcat --pid="$$pid" + $(ADB) logcat --pid="$$pid" screenshots: ./hack/screenshots