vrr/liseur
2
0
Fork 0
mirror of https://github.com/chmouel/liseur.git synced 2026-10-19 01:11:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: Stop a settings test from tripping over its own leftovers

Browse source 
The home-network settings test left the account screen's background
work running after each case finished. Now and then that work woke up
just as the test was putting things back, and the test failed for no
reason of its own. Each case now stops that work before tidying up.
This commit is contained in:
Chmouel Boudjnah 2026-09-24 14:23:33 +02:00
parent 3c08c3fe5f
commit 5a797265b6
1 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
app/src/test/kotlin/com/chmouel/liseur/ui/settings/ServerAccountLocalNetworkTest.kt
View file

@ -1,5 +1,6 @@
package com.chmouel.liseur.ui.settings
import androidx.lifecycle.viewModelScope
import androidx.room.Room
import androidx.work.Configuration
import androidx.work.WorkManager
@ -38,6 +39,8 @@ import javax.crypto.KeyGenerator
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.cancelAndJoin
import kotlinx.coroutines.job
import kotlinx.coroutines.test.TestScope
import kotlinx.coroutines.test.UnconfinedTestDispatcher
import kotlinx.coroutines.test.resetMain
@ -73,6 +76,7 @@ class ServerAccountLocalNetworkTest {
private lateinit var db: LiseurDatabase
private val connects = mutableListOf<Triple<String, String, Boolean>>()
private val models = mutableListOf<ServerAccountViewModel>()
private val kosyncPairings = mutableListOf<String>()
private var blocked = mutableSetOf<String>()
private var permitted = false
@ -115,6 +119,9 @@ class ServerAccountLocalNetworkTest {
try {
body()
} finally {
// A collector still running would hand Room's IO-thread
// emissions to Main while it is being reset.
models.forEach { it.viewModelScope.coroutineContext.job.cancelAndJoin() }
Dispatchers.resetMain()
}
}
@ -521,7 +528,7 @@ class ServerAccountLocalNetworkTest {
bookDao = db.bookDao(),
kosyncAccount = KosyncAccountRepository(db.kosyncPeerDao(), db.syncPeerStateDao()),
localNetwork = FakeAccess(gated),
)
).also(models::add)
}
/** A gate whose answers the test writes rather than the platform. */