vrr/goose
2
0
Fork 0
mirror of https://github.com/block/goose.git synced 2026-10-14 03:42:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 23

fix(desktop): reject array capability metadata
Some checks failed
Cargo Deny / deny (push) Has been cancelled
Details
Unused Dependencies / machete (push) Has been cancelled
Details

Browse source 
Signed-off-by: Jasper Hugo <jasper@spiral.xyz>
This commit is contained in:
Jasper Hugo 2026-10-09 10:23:04 +02:00
parent f2210b009e
commit 75447d86b0
2 changed files with 21 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

20
ui/desktop/src/acp/__tests__/capabilities.test.ts
View file

@ -34,6 +34,26 @@ describe('ACP capabilities', () => {
expect(hasEmptyExtensionSelectionCapability(initializeResponseWithMeta(meta))).toBe(false);
}
});
it('accepts empty-selection capability objects with fields', () => {
expect(
hasEmptyExtensionSelectionCapability(
initializeResponseWithMeta({
goose: { emptyExtensionSelection: { version: 1 } },
})
)
).toBe(true);
});
it.each([
[],
{ goose: [] },
{ goose: { emptyExtensionSelection: [] } },
{ goose: { emptyExtensionSelection: ['supported'] } },
])('rejects array capability metadata: %j', (meta) => {
expect(hasEmptyExtensionSelectionCapability(initializeResponseWithMeta(meta))).toBe(false);
});
it('detects local inference support from Goose metadata', () => {
expect(
hasLocalInferenceCapability(

2
ui/desktop/src/acp/capabilities.ts
View file

@ -67,5 +67,5 @@ export function hasEmptyExtensionSelectionCapability(
}
function isRecord(value: unknown): value is Record<string, unknown> {
return typeof value === 'object' && value !== null;
return typeof value === 'object' && value !== null && !Array.isArray(value);
}