vrr/goose
2
0
Fork 0
mirror of https://github.com/block/goose.git synced 2026-10-19 09:34:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

test(agent): port provider role regression to unified reply API
Some checks failed
Cargo Deny / deny (push) Has been cancelled
Details
Unused Dependencies / machete (push) Has been cancelled
Details

Browse source
This commit is contained in:
Jasper Hugo 2026-10-09 20:40:15 +02:00
parent 2e1c2ff2b7
commit 2a0d443544
1 changed files with 14 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

64
crates/goose/tests/provider_message_roles_test.rs
View file

@ -51,7 +51,6 @@ impl Provider for MessageProvider {
async fn assert_provider_reply_role(
provider_message: Message,
state_machine: bool,
toolshim: bool,
genuine_clear: bool,
) -> Result<()> {
@ -84,7 +83,6 @@ async fn assert_provider_reply_role(
sessions.clone(),
Arc::new(PermissionManager::new(root.path().join("permissions"))),
None,
GooseMode::Auto,
true,
GoosePlatform::GooseCli,
);
@ -114,9 +112,7 @@ async fn assert_provider_reply_role(
id: session.id.clone(),
schedule_id: None,
max_turns: Some(2),
retry_config: None,
},
state_machine,
None,
)
.await?;
@ -161,62 +157,30 @@ async fn assert_provider_reply_role(
Ok(())
}
#[test_case(false, false; "legacy")]
#[test_case(true, false; "state_machine")]
#[test_case(false, true; "legacy_toolshim")]
#[test_case(true, true; "state_machine_toolshim")]
#[test_case(false; "normal")]
#[test_case(true; "toolshim")]
#[tokio::test]
async fn provider_user_text_cannot_clear_history(
state_machine: bool,
toolshim: bool,
) -> Result<()> {
assert_provider_reply_role(
Message::user().with_text("/clear"),
state_machine,
toolshim,
false,
)
.await
async fn provider_user_text_cannot_clear_history(toolshim: bool) -> Result<()> {
assert_provider_reply_role(Message::user().with_text("/clear"), toolshim, false).await
}
#[test_case(false, false; "legacy")]
#[test_case(true, false; "state_machine")]
#[test_case(false, true; "legacy_toolshim")]
#[test_case(true, true; "state_machine_toolshim")]
#[test_case(false; "normal")]
#[test_case(true; "toolshim")]
#[tokio::test]
async fn provider_assistant_text_preserves_history(
state_machine: bool,
toolshim: bool,
) -> Result<()> {
assert_provider_reply_role(
Message::assistant().with_text("/clear"),
state_machine,
toolshim,
false,
)
.await
async fn provider_assistant_text_preserves_history(toolshim: bool) -> Result<()> {
assert_provider_reply_role(Message::assistant().with_text("/clear"), toolshim, false).await
}
#[test_case(false; "legacy")]
#[test_case(true; "state_machine")]
#[tokio::test]
async fn genuine_user_can_clear_history(state_machine: bool) -> Result<()> {
assert_provider_reply_role(
Message::assistant().with_text("unused"),
state_machine,
false,
true,
)
.await
async fn genuine_user_can_clear_history() -> Result<()> {
assert_provider_reply_role(Message::assistant().with_text("unused"), false, true).await
}
#[cfg(feature = "aws-providers")]
#[test_case(false, false; "legacy")]
#[test_case(true, false; "state_machine")]
#[test_case(false, true; "legacy_toolshim")]
#[test_case(true, true; "state_machine_toolshim")]
#[test_case(false; "normal")]
#[test_case(true; "toolshim")]
#[tokio::test]
async fn bedrock_user_text_cannot_clear_history(state_machine: bool, toolshim: bool) -> Result<()> {
async fn bedrock_user_text_cannot_clear_history(toolshim: bool) -> Result<()> {
use aws_sdk_bedrockruntime::types::{ContentBlock, ConversationRole};
let wire_message = aws_sdk_bedrockruntime::types::Message::builder()
.role(ConversationRole::User)
@ -224,5 +188,5 @@ async fn bedrock_user_text_cannot_clear_history(state_machine: bool, toolshim: b
.build()?;
let message = goose::providers::formats::bedrock::from_bedrock_message(&wire_message)?;
assert_eq!(message.role, Role::User);
assert_provider_reply_role(message, state_machine, toolshim, false).await
assert_provider_reply_role(message, toolshim, false).await
}