mirror of
https://github.com/block/goose.git
synced 2026-10-19 09:34:12 +00:00
fix: resolve vision support from the canonical catalog for all providers (#12522)
Some checks failed
Unused Dependencies / machete (push) Has been cancelled
CI / Check GDK Release Configuration (push) Has been cancelled
CI / Check GDK API Reference is Up-to-Date (push) Has been cancelled
Create Minor Release PR / check-version-bump-pr (push) Has been cancelled
Canary / Prepare Version (push) Has been cancelled
Canary / Upload Install Script (push) Has been cancelled
CI / changes (push) Has been cancelled
CI / Build Rust Project on Windows (push) Has been cancelled
MCP Conformance / Build Conformance Binaries (push) Has been cancelled
Live Provider Tests / check-fork (push) Has been cancelled
Publish Docker Image / docker (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
Canary / bundle-windows-cuda (push) Has been cancelled
Create Minor Release PR / release (push) Has been cancelled
Canary / build-cli-linux (push) Has been cancelled
Canary / bundle-macos-arm64 (push) Has been cancelled
Canary / bundle-macos-x64 (push) Has been cancelled
Canary / bundle-windows (push) Has been cancelled
Canary / Release (push) Has been cancelled
CI / goose ACP npm packages (push) Has been cancelled
CI / Check Rust Code Format (push) Has been cancelled
CI / Build and Test Rust Project (push) Has been cancelled
CI / Build Lean ACP Binary (push) Has been cancelled
CI / Check goose-sdk UniFFI (push) Has been cancelled
CI / Test Kotlin GDK package (push) Has been cancelled
CI / Build and Test TLS Backend (native-tls) (push) Has been cancelled
CI / Build and Test TLS Backend (rustls-tls) (push) Has been cancelled
CI / Build and Test Roaming Feature (push) Has been cancelled
CI / Check MSRV (push) Has been cancelled
CI / Lint Rust Code (push) Has been cancelled
CI / Check Generated Schemas are Up-to-Date (push) Has been cancelled
CI / Test and Lint Electron Desktop App (push) Has been cancelled
CI / Test Desktop Updater Install (ubuntu-latest) (push) Has been cancelled
CI / Test Desktop Updater Install (windows-latest) (push) Has been cancelled
MCP Conformance / Conformance 2025-11-25 / 0.1.16 (push) Has been cancelled
MCP Conformance / Conformance 2025-11-25 / 0.2.0-alpha.10 (push) Has been cancelled
MCP Conformance / Conformance 2026-07-28 / 0.2.0-alpha.10 (push) Has been cancelled
Live Provider Tests / changes (push) Has been cancelled
Live Provider Tests / Build Binary (push) Has been cancelled
Live Provider Tests / Smoke Tests (push) Has been cancelled
Live Provider Tests / Smoke Tests (Code Execution) (push) Has been cancelled
Live Provider Tests / Compaction Tests (push) Has been cancelled
Some checks failed
Unused Dependencies / machete (push) Has been cancelled
CI / Check GDK Release Configuration (push) Has been cancelled
CI / Check GDK API Reference is Up-to-Date (push) Has been cancelled
Create Minor Release PR / check-version-bump-pr (push) Has been cancelled
Canary / Prepare Version (push) Has been cancelled
Canary / Upload Install Script (push) Has been cancelled
CI / changes (push) Has been cancelled
CI / Build Rust Project on Windows (push) Has been cancelled
MCP Conformance / Build Conformance Binaries (push) Has been cancelled
Live Provider Tests / check-fork (push) Has been cancelled
Publish Docker Image / docker (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
Canary / bundle-windows-cuda (push) Has been cancelled
Create Minor Release PR / release (push) Has been cancelled
Canary / build-cli-linux (push) Has been cancelled
Canary / bundle-macos-arm64 (push) Has been cancelled
Canary / bundle-macos-x64 (push) Has been cancelled
Canary / bundle-windows (push) Has been cancelled
Canary / Release (push) Has been cancelled
CI / goose ACP npm packages (push) Has been cancelled
CI / Check Rust Code Format (push) Has been cancelled
CI / Build and Test Rust Project (push) Has been cancelled
CI / Build Lean ACP Binary (push) Has been cancelled
CI / Check goose-sdk UniFFI (push) Has been cancelled
CI / Test Kotlin GDK package (push) Has been cancelled
CI / Build and Test TLS Backend (native-tls) (push) Has been cancelled
CI / Build and Test TLS Backend (rustls-tls) (push) Has been cancelled
CI / Build and Test Roaming Feature (push) Has been cancelled
CI / Check MSRV (push) Has been cancelled
CI / Lint Rust Code (push) Has been cancelled
CI / Check Generated Schemas are Up-to-Date (push) Has been cancelled
CI / Test and Lint Electron Desktop App (push) Has been cancelled
CI / Test Desktop Updater Install (ubuntu-latest) (push) Has been cancelled
CI / Test Desktop Updater Install (windows-latest) (push) Has been cancelled
MCP Conformance / Conformance 2025-11-25 / 0.1.16 (push) Has been cancelled
MCP Conformance / Conformance 2025-11-25 / 0.2.0-alpha.10 (push) Has been cancelled
MCP Conformance / Conformance 2026-07-28 / 0.2.0-alpha.10 (push) Has been cancelled
Live Provider Tests / changes (push) Has been cancelled
Live Provider Tests / Build Binary (push) Has been cancelled
Live Provider Tests / Smoke Tests (push) Has been cancelled
Live Provider Tests / Smoke Tests (Code Execution) (push) Has been cancelled
Live Provider Tests / Compaction Tests (push) Has been cancelled
Co-authored-by: elgeom <elgeom@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com>
This commit is contained in:
parent
fc9b2a5be4
commit
04ed836c8c
1 changed files with 22 additions and 1 deletions
|
|
@ -43,7 +43,9 @@ fn apply_canonical_limits(provider_name: &str, model: ModelConfig) -> ModelConfi
|
|||
if provider_name == goose_providers::azure_foundry::AZURE_FOUNDRY_PROVIDER_NAME {
|
||||
model
|
||||
} else {
|
||||
model.with_canonical_limits(provider_name)
|
||||
model
|
||||
.with_canonical_limits(provider_name)
|
||||
.with_canonical_vision_support(provider_name)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -339,3 +341,22 @@ mod azure_foundry_tests {
|
|||
assert_eq!(config.thinking_effort(), None);
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod canonical_vision_tests {
|
||||
use super::*;
|
||||
|
||||
#[test]
|
||||
fn apply_canonical_limits_resolves_vision_support() {
|
||||
let model = apply_canonical_limits("alibaba-token-plan", ModelConfig::new("qwen3.8-flash"));
|
||||
|
||||
assert_eq!(model.supports_vision, Some(true));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn apply_canonical_limits_leaves_unknown_providers_untouched() {
|
||||
let model = apply_canonical_limits("my-custom-provider", ModelConfig::new("some-model"));
|
||||
|
||||
assert_eq!(model.supports_vision, None);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue