mirror of
https://github.com/Alishahryar1/free-claude-code.git
synced 2026-10-21 13:51:18 +00:00
9fe194ed2b
## Why
The Windows installer fails when installing Hermes because its official
installer rejects `-SkipSetup`. Closes #1921.
## How
Pass only `-NonInteractive`, which already skips upstream stages
requiring input. Update the Hermes smoke stub to reject unsupported
parameters and add a focused installation regression scenario for
Windows PowerShell and PowerShell 7.
<!-- greptile_comment -->
<!-- greptile_summary -->
<h2><a
href="https://app.greptile.com/api/retrigger?id=70242636"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img
alt="Retrigger"
src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"
align="right"></picture></a>Confidence Score: 5/5</h2>
<!-- greptile-risk -->
No identified issue blocks merging.
What we checked:
- The wrapper was updated to pass only -NonInteractive, and the
installer was found to declare -NonInteractive but not -SkipSetup. <a
href="https://www.greptile.com/trex"><img alt="T-Rex"
src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg"
height="16" align="absmiddle"></a>
- Contract validation showed upstream Stage-Setup and Stage-Gateway
exited early and did not invoke Hermes when the -NonInteractive flag was
used. <a href="https://www.greptile.com/trex"><img alt="T-Rex"
src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg"
height="16" align="absmiddle"></a>
- The contract checks reported exit codes 1 and 0 for the parallel
checks, indicating that no real Hermes installation was attempted. <a
href="https://www.greptile.com/trex"><img alt="T-Rex"
src="https://greptile-static-assets.s3.amazonaws.com/trex/trex_green.svg"
height="16" align="absmiddle"></a>
<details open><summary>Summary</summary>
The PR removes an unsupported argument from the Windows Hermes installer
call and updates the smoke fixture and assertions to check
noninteractive installation. The fetched installer accepts the remaining
argument and skips interactive setup when it is set. This lets Windows
users install Hermes without being prompted for setup. No actionable
issues were found.
</details>
<!-- greptile_confidence_score:5 -->
<sub>Reviews (1) · Last reviewed commit: ["fix: use supported Hermes
Windows
instal..."](
|
||
|---|---|---|
| .. | ||
| update | ||
| check_version_policy.py | ||
| ci.ps1 | ||
| ci.sh | ||
| install-muse.ps1 | ||
| install.ps1 | ||
| install.sh | ||
| publish_release.py | ||
| uninstall-muse.ps1 | ||
| uninstall.ps1 | ||
| uninstall.sh | ||
| validate_release.py | ||
