codeburn/tests/date-range-filter.test.ts
Resham Joshi 151509a1fb
fix(cache-lock): coalesce heartbeat ticks; make time-sensitive tests deterministic (#1559)
* fix(cache-lock): coalesce heartbeat ticks so the fence never waits behind a backlog

Each interval tick queued a full heartbeat in the owner serializer, so an
interval firing faster than a tick completes grew the queue without bound and
verifyStillOwner waited behind all of it. The 1ms-heartbeat fence test hit its
30s timeout on a loaded runner and retried up to 10 times, which is the silent
cache-lock suite hang in CI.

* test(menubar): hold off the helper's SIGTERM until the stand-in app records its status

The relaunch helper signals the app as soon as the CLI child is reaped, which
could land between the stand-in's fopen and fclose and leave an empty status
file. Also wait for the recorder's full line instead of a fixed sleep.

* test: pin day-boundary tests so they pass at any time of day

CLI children that query "today" now run in a fixed-offset zone where it is
about noon on the UTC date (tests/fixtures/noon-tz.ts), so fixtures a little in
the past are always today; the old clamp to UTC midnight put them in the future
for the first minutes of the day and zeroed the counts. The month-scoped budget
and project-filter fixtures get the same treatment (the latter also failed on
days 1-5 of every month), the cursor lookback case derives its start from now
instead of a date that ages out on 1 Oct, and the renderer tests that format a
stamp from a few hours back pin the clock to mid-day. The session drawer date
is formatted in the local zone, so its expectation is too.

* test: derive dated fixtures from the clock so rolling windows never age them out

The six-month --period all window and the sync ledger's six-month prune
dropped fixtures fixed at April-July 2026 from 1 Nov 2026 on. CLI fixtures now
sit 30 days back (utcDaysAgo), the ledger and push tests pin Date to July 2026,
the --to-only range uses yesterday, and the date-picker tests pin mid-month so
two days back is on the calendar they open (they failed on the 1st and 2nd of
every month). The noon-tz helper moves to tests/fixtures/clock.ts.

* test(desktop): give spawned stand-ins room to boot before the silence window

The watchdog and graceful-kill tests used 1-1.5s silence windows, and the
window before a child's first byte includes node's boot. On a loaded machine
the child was signalled before it installed its handler or wrote its byte.
The windows are now 3s and the last-byte test measures from the byte the child
stamps. The killAll and fallback-scheduler tests wait on their condition with
a 15s deadline instead of a 2-3s one.
2026-09-25 05:06:43 +02:00

143 lines
5.9 KiB
TypeScript

import { afterEach, describe, it, expect, vi } from 'vitest'
import { formatDateRangeLabel, formatDayRangeLabel, parseDateRangeFlags, parseDayFlag, shiftDay } from '../src/cli-date.js'
afterEach(() => {
vi.useRealTimers()
})
describe('parseDateRangeFlags', () => {
it('returns null when neither flag is provided', () => {
expect(parseDateRangeFlags(undefined, undefined)).toBeNull()
})
it('parses a symmetric range in local time', () => {
const range = parseDateRangeFlags('2026-04-07', '2026-04-10')
expect(range).not.toBeNull()
expect(range!.start.getFullYear()).toBe(2026)
expect(range!.start.getMonth()).toBe(3)
expect(range!.start.getDate()).toBe(7)
expect(range!.start.getHours()).toBe(0)
expect(range!.end.getDate()).toBe(10)
expect(range!.end.getHours()).toBe(23)
expect(range!.end.getMinutes()).toBe(59)
expect(range!.end.getSeconds()).toBe(59)
})
it('accepts --from alone (open-ended to today 23:59:59)', () => {
const range = parseDateRangeFlags('2026-04-01', undefined)
expect(range).not.toBeNull()
expect(range!.start.getDate()).toBe(1)
expect(range!.end.getHours()).toBe(23)
})
it('accepts --to alone with a 6-month default start', () => {
// Previously the missing --from defaulted to epoch (1970), opening a
// 55-year scan window that was almost never what the user meant. The
// default is now 6 months back from now, matching the dashboard's
// "6 Months" period boundary.
const to = new Date(Date.now() - 24 * 3600_000)
const toDay = `${to.getFullYear()}-${String(to.getMonth() + 1).padStart(2, '0')}-${String(to.getDate()).padStart(2, '0')}`
const range = parseDateRangeFlags(undefined, toDay)
expect(range).not.toBeNull()
expect(range!.start.getTime()).toBeGreaterThan(new Date(0).getTime())
const sixMonthsMs = 6 * 31 * 24 * 60 * 60 * 1000
const ageMs = Date.now() - range!.start.getTime()
expect(ageMs).toBeLessThanOrEqual(sixMonthsMs + 1000)
expect(ageMs).toBeGreaterThanOrEqual(sixMonthsMs - 1000)
expect(range!.end.getDate()).toBe(to.getDate())
})
it('throws when --from > --to', () => {
expect(() => parseDateRangeFlags('2026-04-10', '2026-04-07'))
.toThrow('--from must not be after --to')
})
it('throws on a non-ISO string', () => {
expect(() => parseDateRangeFlags('April 7', undefined))
.toThrow('Invalid date format')
})
it('throws on wrong digit count', () => {
expect(() => parseDateRangeFlags('26-4-7', undefined))
.toThrow('Invalid date format')
})
it('rejects month/day overflow instead of silently rolling forward', () => {
// Without overflow validation, JS Date silently turns Feb 31 into Mar 3
// and 13/32 into 02/01 of the following year. That made `--from
// 2026-02-31 --to 2026-03-15` quietly drop sessions on Feb 28 - Mar 2.
expect(() => parseDateRangeFlags('2026-02-31', '2026-03-15'))
.toThrow('Invalid date "2026-02-31"')
expect(() => parseDateRangeFlags('2026-13-01', undefined))
.toThrow('Invalid date "2026-13-01"')
expect(() => parseDateRangeFlags('2026-04-31', undefined))
.toThrow('Invalid date "2026-04-31"')
expect(() => parseDateRangeFlags(undefined, '2026-02-30'))
.toThrow('Invalid date "2026-02-30"')
// Leap-day check: 2024 is a leap year, 2025 is not.
expect(parseDateRangeFlags('2024-02-29', '2024-03-01')).not.toBeNull()
expect(() => parseDateRangeFlags('2025-02-29', undefined))
.toThrow('Invalid date "2025-02-29"')
})
it('same day is valid (start midnight, end 23:59:59)', () => {
const range = parseDateRangeFlags('2026-04-10', '2026-04-10')
expect(range).not.toBeNull()
expect(range!.start.getDate()).toBe(10)
expect(range!.end.getDate()).toBe(10)
})
it('formats custom range labels consistently', () => {
expect(formatDateRangeLabel('2026-04-07', '2026-04-10')).toBe('2026-04-07 to 2026-04-10')
expect(formatDateRangeLabel(undefined, '2026-04-10')).toBe('all to 2026-04-10')
expect(formatDateRangeLabel('2026-04-07', undefined)).toBe('2026-04-07 to today')
})
})
describe('parseDayFlag', () => {
it('returns null when no day is provided', () => {
expect(parseDayFlag(undefined)).toBeNull()
})
it('parses an explicit day as local midnight through end of day', () => {
const selected = parseDayFlag('2026-04-10')
expect(selected).not.toBeNull()
expect(selected!.day).toBe('2026-04-10')
expect(selected!.label).toBe('Day (2026-04-10)')
expect(selected!.range.start.getFullYear()).toBe(2026)
expect(selected!.range.start.getMonth()).toBe(3)
expect(selected!.range.start.getDate()).toBe(10)
expect(selected!.range.start.getHours()).toBe(0)
expect(selected!.range.end.getDate()).toBe(10)
expect(selected!.range.end.getHours()).toBe(23)
expect(selected!.range.end.getMinutes()).toBe(59)
expect(selected!.range.end.getSeconds()).toBe(59)
})
it('resolves yesterday as the previous local calendar day after midnight', () => {
vi.useFakeTimers()
vi.setSystemTime(new Date(2026, 4, 23, 0, 5, 0))
const selected = parseDayFlag('yesterday')
expect(selected!.day).toBe('2026-05-22')
expect(selected!.range.start.getDate()).toBe(22)
expect(selected!.range.end.getDate()).toBe(22)
})
it('supports today and day shifting', () => {
vi.useFakeTimers()
vi.setSystemTime(new Date(2026, 4, 23, 12, 0, 0))
expect(parseDayFlag('today')!.day).toBe('2026-05-23')
expect(formatDayRangeLabel('2026-05-22')).toBe('Day (2026-05-22)')
expect(shiftDay('2026-05-22', -1)).toBe('2026-05-21')
expect(shiftDay('2026-05-22', 1)).toBe('2026-05-23')
})
it('rejects malformed or overflowing day values', () => {
expect(() => parseDayFlag('May 22')).toThrow('Invalid date format')
expect(() => parseDayFlag('2026-02-31')).toThrow('Invalid date "2026-02-31"')
expect(() => shiftDay('2026-13-01', 1)).toThrow('Invalid date "2026-13-01"')
})
})