4 commits

Author	SHA1	Message	Date
Resham Joshi	b8cc0edcbf	0.9.25 round 2: fixes found testing the built apps (#1517) ... * fix: open menu bar Settings centered on the active screen The window was positioned at a 520x380 placeholder while SwiftUI's own minimum is 880x620, so the grown window kept its top-left corner and ran off the bottom-right edge. Size the window from the view's minimum, place it with a tested pure function, and honour a saved frame only while it still fits on one of today's screens. * fix: say where the telemetry toggle is managed when the desktop app owns it A desktop telemetry.v1.json with enabled:false locks the menu bar toggle off, so clicking it does nothing. Name the desktop app's Privacy & data pane in the caption, and pin the four desktop/veto combinations plus the standalone case in tests. * fix(desktop): export the provider id, and never swallow a rejected setter The export pane built its provider list from `current.providers`, which is keyed on the lowercased display name. Five of the seventeen providers on a real corpus ("cursor agent", "grok build", "kimi code", "hermes agent", "grok bot") are not valid ids, so vProvider rejected them as bad-args. `exportNow` had a try/finally and no catch, so the rejection produced no toast and no file: the button did nothing. Use detectedProviders, which already resolves ids from providerDetails, and toast on rejection. The telemetry consent toggle swallowed its rejection the same way. * fix(desktop): warm only the selected period, and only while visible The post-paint sweep warmed all six standard periods x seven reports plus the provider overviews: up to 48 serve-routed queries, ~18 CPU-seconds a minute for five minutes and 2.79 GB peak RSS on a real corpus, and it ran with the window hidden. It now warms the selected period's reports (its own overview is already under that memo key from the visible poll) and the other providers' headlines for that same period, holding before every request while a user fetch is in flight or the window is hidden. Other periods take the ordinary on-demand path. Also corrects two comments that claimed background priority lets a click jump ahead: spawnCli takes the serve fast path before priority is read, and the resident child answers FIFO. * fix(desktop): answer the click, report the write, tell the truth about the Claude login Nine bridge setters in Settings attached only .then(), so a rejected envelope produced no toast and the control read as if it had ignored the click. One shared helper toasts the rejection, per pane fallback wording. Telemetry save() swallowed write errors while setEnabled returned the in-memory status, so the UI could show ON while the file the macOS menu bar app reads still said OFF. The setters now carry persisted:boolean and the renderer toasts when it is false; the write goes through the existing atomic writeFileAtomic (temp file, rename) so a crash cannot tear it. The Claude card called a logged-in Claude Code 2.x user "disconnected" forever, because the credential lives only in the keychain and the first poll never reads it. A new darwin-only keychainUnchecked state says we have not looked yet and offers the forced read, keeping the login instructions for the genuinely-logged-out case. ConnectAffordance's toggle is renamed to what it does: it discloses instructions. * fix: retry tax is the cost of retried edit turns, not a multiple of spend * stop the change guard watching a Warp path it can never stat * apply a menu bar language change in place instead of relaunching * keep honoring WARP_DB_PATH in the change guard * restart a menu bar too old to watch AppleLanguages * one rebuild per language change, and no global bundle in tests * fix(desktop): a forced quota refresh must not join the poll it just aborted Check now / Refresh / ⌘R invalidated the quota service and then handed the caller the background fetch it had just aborted, so every provider failed its generation check and resolved disconnected: the click repainted every card as logged out without ever reading the keychain, and Claude showed "Not connected. Log in with the Claude CLI." A call now joins an in-flight run only when that run is at least as privileged, so a keychain-allowed call starts its own; a second forced click still joins the first, which keeps the single macOS prompt. A superseded run hands its caller the run that replaced it instead of its own abort artefacts. retainOnFailure also holds accessDenied through a keychainUnchecked poll, so the "Allow in keychain" guidance is not replaced by "Check now" one cycle after the user denied the prompt. * fix(desktop): stop the sweep churning, and never spend a query on an abandoned one The prefetch effect depended on the detected-provider entries, whose costs move on every overview poll, so it was torn down and restarted each cadence tick: a warm slower than the interval was discarded and re-issued forever. It now depends on the provider ids alone, and a finished warm is kept for its own period/provider key even if the effect was torn down meanwhile — only a config-generation change makes a result wrong. Both loops re-test cancellation and the memo after the hold, which has no bound, so an abandoned sweep issues nothing and a section the user visited meanwhile is not parsed again. The hidden half of the hold waits on visibilitychange instead of waking the renderer every two seconds for a window nobody is looking at. * fix(desktop): never offer a provider id the CLI will reject, and keep the keychain note detectedProviders applied the round-trip filter only to the legacy providers map; a providerDetails id with a space reached the picker and the export as a --provider value the main process rejects. The Plans settings row showed the "not read your login yet" line without the note that macOS may ask once for keychain access, which the Plans card does show.	2026-09-21 13:53:45 +02:00
Resham Joshi	43608c2558	desktop and menu bar: six-language localization (#1493) ... The desktop app and the macOS menu bar can now run in English, French, Japanese, Korean, Simplified Chinese and Traditional Chinese. A Language setting in the desktop Settings picks the language or follows the system, and the choice is shared so the menu bar switches with it, relaunching to pick up the language with a retry so a switch never leaves it down. Every user-facing string in the desktop renderer goes through a local lookup table, 1,249 keys per language, no framework and no network. The menu bar gains four .lproj to join English and Simplified Chinese, 626 keys each. A completeness gate fails the build if any language is missing a key, in both the desktop catalogs and the menu bar coverage suite. Fonts fall back per language so Japanese, Korean and both Chinese render their correct glyph forms, and dates and numbers format for the locale with values unchanged. English output is byte-identical. Strings produced by the CLI engine stay English until the CLI is localized, a separate effort. Validated live in all six languages: no missing text, no clipping, correct fonts, numbers unchanged, and the menu bar switching for every language.	2026-09-19 03:25:46 -07:00
ozymandiashh	9eebfda627	feat(menubar): add Simplified Chinese (zh-Hans) localization ... All 533 catalog keys translated into zh-Hans, so the menubar app now follows the system language with no setting to find and no third-party library. AppKit picks the table: `CFBundleLocalizations` in both packaging scripts advertises `en` and `zh-Hans`, which is also what puts the app under System Settings > Language & Region so a user can override the language for CodeBurn alone. Wording follows macOS system apps rather than a literal gloss: 立即刷新, 断开连接, 存储并连接, 载入配额, 再试一次. Product nouns stay as users already know them: provider, model and plan names (Claude, Codex, Gemini, Opus, Sonnet, Antigravity), Token, Dock, API, OAuth, shell commands and file paths, currency codes. Format specifiers are identical to the English entry in count and argument order. `%%` is a literal percent sign and not an argument, so it may move where Chinese word order demands it ("%@ · %@ 达到 100%%"); the argument-consuming specifiers may not, because String(format:) binds them positionally. The next commit's test enforces exactly that distinction. Numbers, dates and currency are untouched: they already went through NumberFormatter / DateFormatter / asCurrency(), and `L(_:_:)` only substitutes values those produced.	2026-09-12 15:21:49 -07:00
ozymandiashh	d62857ea4e	feat(menubar): route every user-facing string through a strings catalog ... Groundwork for #1219. The menubar app hardcoded ~530 English strings across Views/, the presentation structs, the status-item menu and the update alerts, so there was nothing for a translator to translate. Every user-facing literal now goes through `L(_:)` / `L(_:_:)`, which look the string up in `Localizable.strings` in the SwiftPM target resource bundle. The key *is* the English copy, so English stays the development language and a missing translation degrades to correct English instead of a dotted identifier. `en.lproj` is therefore an identity table; it exists so the bundle advertises `en` and so a translation can be diffed against it. Why the lookups are explicit rather than relying on SwiftUI's implicit `LocalizedStringKey`: SwiftPM emits target resources into a sibling bundle (`CodeBurnMenubar_CodeBurnMenubar.bundle`) that the packaging scripts copy into `Contents/Resources`. `Bundle.main` has no `.lproj` at all, so `Text("literal")` would always miss. Naming `Bundle.module` is the one form that resolves the same way in `swift run`, in `swift test` and in the packaged `.app`. Enum raw values that double as identity (`Period`, `MenubarScope`, `InsightMode`, `AccentPreset`, `ProviderFilter`) keep their raw value and gain a `displayLabel`, so persistence and cache keys are untouched by translation. Three display-only date formatters that were pinned to `en_US_POSIX` with fixed patterns now use `setLocalizedDateFormatFromTemplate`, and the calendar popover's weekday row comes from the locale's own symbols. The `yyyy-MM-dd` formatter stays POSIX: it parses and builds data keys, not display text. Not extracted, deliberately: provider, model and plan names; units; currency codes; shell commands and paths; quota window labels that policy code matches on by English substring (`QuotaSummary.headlineWindow`); and anything the `codeburn` CLI produces. Also copies the SwiftPM resource bundle into the app in build-local.sh, using the named-bundle + `[[ -d ]]` pattern package-app.sh already uses. Without it the assembled app finds no strings table (and already trapped on first icon load, the resource-bundle half of #1262).	2026-09-12 15:21:49 -07:00